[open-ils-commits] [GIT] Evergreen ILS branch master updated. 5df06a15efdf0a48e3772a882b95a1e970d420a3

[Evergreen Git]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Evergreen ILS".

The branch, master has been updated
       via  5df06a15efdf0a48e3772a882b95a1e970d420a3 (commit)
      from  e6a1e7fdcfc20499f3094111e9039eb3f5d86dfe (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 5df06a15efdf0a48e3772a882b95a1e970d420a3
Author: Dan Wells <dbw2 at calvin.edu>
Date:   Tue Aug 30 21:50:19 2016 -0400

    LP#1618624 Fix thinko in adjust-to-zero
    
    It appears that this test was written for an 'unless' instead of
    an 'if'.  'if' seems just as natural here, so let's go that route.
    
    This should prevent us from closing circulations prematurely, and
    also close them when we need to.
    
    Signed-off-by: Dan Wells <dbw2 at calvin.edu>
    Signed-off-by: Kathy Lussier <klussier at masslnc.org>

diff --git a/Open-ILS/src/perlmods/lib/OpenILS/Application/Circ/Money.pm b/Open-ILS/src/perlmods/lib/OpenILS/Application/Circ/Money.pm
index 666b402..4b27e22 100644
--- a/Open-ILS/src/perlmods/lib/OpenILS/Application/Circ/Money.pm
+++ b/Open-ILS/src/perlmods/lib/OpenILS/Application/Circ/Money.pm
@@ -1051,7 +1051,7 @@ sub adjust_bills_to_zero_manual {
         # now we see if we can close the transaction
         # same logic as make_payments();
         my $circ = $e->retrieve_action_circulation($xact_id);
-        if ($circ and !$CC->can_close_circ($e, $circ)) {
+        if (!$circ or $CC->can_close_circ($e, $circ)) {
             # we don't check to see if the xact is already closed.  since the
             # xact had a negative balance, it should not have been closed, so
             # assume 'now' is the correct close time regardless.

-----------------------------------------------------------------------

Summary of changes:
 .../perlmods/lib/OpenILS/Application/Circ/Money.pm |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)


hooks/post-receive
-- 
Evergreen ILS