[open-ils-commits] [GIT] Evergreen ILS branch master updated. 47f5e9a07899fc684875e3e12b92db7357066370

[Evergreen Git]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Evergreen ILS".

The branch, master has been updated
       via  47f5e9a07899fc684875e3e12b92db7357066370 (commit)
      from  7318d457e9e1bc3cce0086326ba2d60527c32408 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 47f5e9a07899fc684875e3e12b92db7357066370
Author: Galen Charlton <gmc at equinoxinitiative.org>
Date:   Wed Mar 22 12:25:41 2017 -0400

    LP#1668720: remove browser console noise for OPAC
    
    This patch fixes a case where JavaScript used in the OPAC
    attempts to set the value of a #client_tz_id input on all
    pages, even though only the login page has such an input.
    
    To test:
    
    [1] Load the OPAC homepage and open the JavaScript console/developer tools.
        Note that there's a "Cannot set property 'value' of null"
        error.
    [2] Apply the patch and try again; this time there shouldn't
        be such an error.
    [3] Open the login page, and verify, using developer tools,
        that the hidden client_tz_id input does have its value
        set to the client timezone.
    
    Signed-off-by: Galen Charlton <gmc at equinoxinitiative.org>
    Signed-off-by: Kathy Lussier <klussier at masslnc.org>

diff --git a/Open-ILS/src/templates/opac/parts/js.tt2 b/Open-ILS/src/templates/opac/parts/js.tt2
index 245af43..4d5b400 100644
--- a/Open-ILS/src/templates/opac/parts/js.tt2
+++ b/Open-ILS/src/templates/opac/parts/js.tt2
@@ -152,5 +152,5 @@ var aou_hash = {
   </script>
 [% END %]
 
-<script type="text/javascript">$('client_tz_id').value = OpenSRF.tz</script>
+<script type="text/javascript">if ($('client_tz_id')) { $('client_tz_id').value = OpenSRF.tz }</script>
 [%- END; # want_dojo -%]

-----------------------------------------------------------------------

Summary of changes:
 Open-ILS/src/templates/opac/parts/js.tt2 |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)


hooks/post-receive
-- 
Evergreen ILS