[open-ils-commits] [GIT] Evergreen ILS branch master updated. 06b170f908764312b59414ffce340c955fa94dfc

[Evergreen Git]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Evergreen ILS".

The branch, master has been updated
       via  06b170f908764312b59414ffce340c955fa94dfc (commit)
       via  86f73e85f182701f4839a6afc2999eab0e727a9a (commit)
       via  170acf44e558b659bb9c19e5be4a4b54e4eb66ca (commit)
      from  3c35e94bc037fa8ebb08b302d8e79f53b5ac004b (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 06b170f908764312b59414ffce340c955fa94dfc
Author: Galen Charlton <gmc at equinoxinitiative.org>
Date:   Mon May 1 15:04:56 2017 -0400

    LP#1684984: stamp DB update
    
    Signed-off-by: Galen Charlton <gmc at equinoxinitiative.org>

diff --git a/Open-ILS/src/sql/Pg/002.schema.config.sql b/Open-ILS/src/sql/Pg/002.schema.config.sql
index 2250678..97ef039 100644
--- a/Open-ILS/src/sql/Pg/002.schema.config.sql
+++ b/Open-ILS/src/sql/Pg/002.schema.config.sql
@@ -90,7 +90,7 @@ CREATE TRIGGER no_overlapping_deps
     BEFORE INSERT OR UPDATE ON config.db_patch_dependencies
     FOR EACH ROW EXECUTE PROCEDURE evergreen.array_overlap_check ('deprecates');
 
-INSERT INTO config.upgrade_log (version, applied_to) VALUES ('1034', :eg_version); -- rhamby/gmcharlt/dyrcona
+INSERT INTO config.upgrade_log (version, applied_to) VALUES ('1035', :eg_version); -- dyrcona/gmcharlt
 
 CREATE TABLE config.bib_source (
 	id		SERIAL	PRIMARY KEY,
diff --git a/Open-ILS/src/sql/Pg/upgrade/XXXX.data.remove_ingest.disable_metabib_field_entry.sql b/Open-ILS/src/sql/Pg/upgrade/1035.data.remove_ingest.disable_metabib_field_entry.sql
similarity index 79%
rename from Open-ILS/src/sql/Pg/upgrade/XXXX.data.remove_ingest.disable_metabib_field_entry.sql
rename to Open-ILS/src/sql/Pg/upgrade/1035.data.remove_ingest.disable_metabib_field_entry.sql
index 091c618..64c865a 100644
--- a/Open-ILS/src/sql/Pg/upgrade/XXXX.data.remove_ingest.disable_metabib_field_entry.sql
+++ b/Open-ILS/src/sql/Pg/upgrade/1035.data.remove_ingest.disable_metabib_field_entry.sql
@@ -1,6 +1,6 @@
 BEGIN;
 
--- SELECT evergreen.upgrade_deps_block_check('XXXX', :eg_version);
+INSERT INTO config.upgrade_log (version, applied_to) VALUES ('1035', :eg_version); -- dyrcona/gmcharlt
 
 -- Per Lp bug 1684984, the config.internal_flag,
 -- ingest.disable_metabib_field_entry, was made obsolete by the

commit 86f73e85f182701f4839a6afc2999eab0e727a9a
Author: Jason Stephenson <jason at sigio.com>
Date:   Sat Apr 22 08:28:34 2017 -0400

    LP#1684984: Remove obsolete ingest.disable_metabib_field_entry flag.
    
    Add release note.
    
    Signed-off-by: Jason Stephenson <jason at sigio.com>
    Signed-off-by: Galen Charlton <gmc at equinoxinitiative.org>

diff --git a/docs/RELEASE_NOTES_NEXT/Administration/obsolete_internal_flag_removed.adoc b/docs/RELEASE_NOTES_NEXT/Administration/obsolete_internal_flag_removed.adoc
new file mode 100644
index 0000000..d5b3215
--- /dev/null
+++ b/docs/RELEASE_NOTES_NEXT/Administration/obsolete_internal_flag_removed.adoc
@@ -0,0 +1,7 @@
+Obsolete Internal Flag Removed
+^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
+
+An obsolete, and unused, ingest.disable_metabib_field_entry internal
+flag was removed from the config.internal_flags table.  It was
+rendered obsolete by the addition of the 3 flags to control the
+browse, search, and facet indexing.

commit 170acf44e558b659bb9c19e5be4a4b54e4eb66ca
Author: Jason Stephenson <jason at sigio.com>
Date:   Fri Apr 21 20:42:49 2017 -0400

    LP#1684984: Remove obsolete ingest.disable_metabib_field_entry flag.
    
    Per discussion in IRC, the ingest.disable_metabib_field_entry internal
    flag was obsoleted by the addition of the ingest.skip_browse_indexing,
    ingest.skip_search_indexing, and ingest.skip_facet_indexing
    flags. Since ingest.disable_metabib_field_entry is not used anywhere
    in the database, this branch removes it.
    
    Signed-off-by: Jason Stephenson <jason at sigio.com>
    Signed-off-by: Galen Charlton <gmc at equinoxinitiative.org>

diff --git a/Open-ILS/src/sql/Pg/002.schema.config.sql b/Open-ILS/src/sql/Pg/002.schema.config.sql
index d23ebf1..2250678 100644
--- a/Open-ILS/src/sql/Pg/002.schema.config.sql
+++ b/Open-ILS/src/sql/Pg/002.schema.config.sql
@@ -44,7 +44,6 @@ INSERT INTO config.internal_flag (name) VALUES ('ingest.reingest.force_on_same_m
 INSERT INTO config.internal_flag (name) VALUES ('ingest.disable_located_uri');
 INSERT INTO config.internal_flag (name) VALUES ('ingest.disable_metabib_full_rec');
 INSERT INTO config.internal_flag (name) VALUES ('ingest.disable_metabib_rec_descriptor');
-INSERT INTO config.internal_flag (name) VALUES ('ingest.disable_metabib_field_entry');
 INSERT INTO config.internal_flag (name) VALUES ('ingest.assume_inserts_only');
 INSERT INTO config.internal_flag (name) VALUES ('ingest.skip_browse_indexing');
 INSERT INTO config.internal_flag (name) VALUES ('ingest.skip_search_indexing');
diff --git a/Open-ILS/src/sql/Pg/t/lp1684984-remove-ingest.disable_metabib_field_entry.pg b/Open-ILS/src/sql/Pg/t/lp1684984-remove-ingest.disable_metabib_field_entry.pg
new file mode 100644
index 0000000..45bb222
--- /dev/null
+++ b/Open-ILS/src/sql/Pg/t/lp1684984-remove-ingest.disable_metabib_field_entry.pg
@@ -0,0 +1,13 @@
+BEGIN;
+
+SELECT plan(1);
+
+-- Check that config.internal_flag ingest.disable_metabib_field_entry does not exist.
+SELECT is_empty(
+    'SELECT * FROM config.internal_flag WHERE name = $$ingest.disable_metabib_field_entry$$',
+    'config.internal_flag ingest.disable_metabib_field_entry does not exist'
+);
+
+SELECT * FROM finish();
+
+ROLLBACK;
diff --git a/Open-ILS/src/sql/Pg/upgrade/XXXX.data.remove_ingest.disable_metabib_field_entry.sql b/Open-ILS/src/sql/Pg/upgrade/XXXX.data.remove_ingest.disable_metabib_field_entry.sql
new file mode 100644
index 0000000..091c618
--- /dev/null
+++ b/Open-ILS/src/sql/Pg/upgrade/XXXX.data.remove_ingest.disable_metabib_field_entry.sql
@@ -0,0 +1,13 @@
+BEGIN;
+
+-- SELECT evergreen.upgrade_deps_block_check('XXXX', :eg_version);
+
+-- Per Lp bug 1684984, the config.internal_flag,
+-- ingest.disable_metabib_field_entry, was made obsolete by the
+-- addition of the ingest.skip_browse_indexing,
+-- ingest.skip_search_indexing, and ingest.skip_facet_indexing flags.
+-- Since it is not used in the database, we delete it.
+DELETE FROM config.internal_flag
+WHERE name = 'ingest.disable_metabib_field_entry';
+
+COMMIT;

-----------------------------------------------------------------------

Summary of changes:
 Open-ILS/src/sql/Pg/002.schema.config.sql          |    3 +--
 ...84-remove-ingest.disable_metabib_field_entry.pg |   13 +++++++++++++
 ...a.remove_ingest.disable_metabib_field_entry.sql |   13 +++++++++++++
 .../obsolete_internal_flag_removed.adoc            |    7 +++++++
 4 files changed, 34 insertions(+), 2 deletions(-)
 create mode 100644 Open-ILS/src/sql/Pg/t/lp1684984-remove-ingest.disable_metabib_field_entry.pg
 create mode 100644 Open-ILS/src/sql/Pg/upgrade/1035.data.remove_ingest.disable_metabib_field_entry.sql
 create mode 100644 docs/RELEASE_NOTES_NEXT/Administration/obsolete_internal_flag_removed.adoc


hooks/post-receive
-- 
Evergreen ILS