[open-ils-commits] [GIT] Evergreen ILS branch rel_2_12 updated. 75bd47794fe3710f110ba9c1b3dd50da0b815c87

[Evergreen Git]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Evergreen ILS".

The branch, rel_2_12 has been updated
       via  75bd47794fe3710f110ba9c1b3dd50da0b815c87 (commit)
       via  c5f33f473a901f7021c55002eb88613baacf0909 (commit)
      from  d5142a3ecfc3938eff8d27ddd05e1fda87af3a5a (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 75bd47794fe3710f110ba9c1b3dd50da0b815c87
Author: Galen Charlton <gmc at equinoxinitiative.org>
Date:   Mon May 1 14:47:58 2017 -0400

    LP#1667221: (follow-up) remove comment that is now a lie
    
    Also, here's a test plan:
    
    [1] Edit /openils/conf/oils_sip.xml and set the currency
        defined in the implementation section to be something
        other than USD.
    [2] Start the SIP server and perform a patron information
        request; note that the BH field in the response contains
        'USD'.
    [3] Apply the patch and restart the SIP server.
    [4] Repeat step 2; this time, the currency should be whatever
        is specified in oils_sip.xml.
    [5] Comment out the currency section in oils_sip.xml and restart
        the SIP server.
    [6] Repeat step 2; this time, the currency should be back to 'USD'.
    
    Signed-off-by: Galen Charlton <gmc at equinoxinitiative.org>

diff --git a/Open-ILS/src/perlmods/lib/OpenILS/SIP/Patron.pm b/Open-ILS/src/perlmods/lib/OpenILS/SIP/Patron.pm
index 706db2c..34972cc 100644
--- a/Open-ILS/src/perlmods/lib/OpenILS/SIP/Patron.pm
+++ b/Open-ILS/src/perlmods/lib/OpenILS/SIP/Patron.pm
@@ -427,7 +427,7 @@ sub check_password {
         $self->{editor},$self->{user}->id, $pwd);
 }
 
-sub currency {              # not really implemented
+sub currency {
     my $self = shift;
     syslog('LOG_DEBUG', 'OILS: Patron->currency()');
     return OpenILS::SIP->config()->{implementation_config}->{currency} || 'USD';

commit c5f33f473a901f7021c55002eb88613baacf0909
Author: Jeff Davis <jdavis at sitka.bclibraries.ca>
Date:   Mon Feb 20 17:20:26 2017 -0800

    LP#1667221: use library currency as SIP patron currency instead of always using USD
    
    Signed-off-by: Jeff Davis <jdavis at sitka.bclibraries.ca>
    Signed-off-by: Galen Charlton <gmc at equinoxinitiative.org>

diff --git a/Open-ILS/src/perlmods/lib/OpenILS/SIP/Patron.pm b/Open-ILS/src/perlmods/lib/OpenILS/SIP/Patron.pm
index 0845084..706db2c 100644
--- a/Open-ILS/src/perlmods/lib/OpenILS/SIP/Patron.pm
+++ b/Open-ILS/src/perlmods/lib/OpenILS/SIP/Patron.pm
@@ -430,7 +430,7 @@ sub check_password {
 sub currency {              # not really implemented
     my $self = shift;
     syslog('LOG_DEBUG', 'OILS: Patron->currency()');
-    return 'USD';
+    return OpenILS::SIP->config()->{implementation_config}->{currency} || 'USD';
 }
 
 sub fee_amount {

-----------------------------------------------------------------------

Summary of changes:
 Open-ILS/src/perlmods/lib/OpenILS/SIP/Patron.pm |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)


hooks/post-receive
-- 
Evergreen ILS