[open-ils-commits] [GIT] Evergreen ILS branch master updated. a11aca1282575bb13b9b904a1d8898c5109ac1dd

[Evergreen Git]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Evergreen ILS".

The branch, master has been updated
       via  a11aca1282575bb13b9b904a1d8898c5109ac1dd (commit)
      from  077d0548765e0fb264b7df2db665a05423b4f5d5 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit a11aca1282575bb13b9b904a1d8898c5109ac1dd
Author: blake <blake at mobiusconsortium.org>
Date:   Fri Jul 1 12:01:04 2016 -0500

    LP1244354 Unnecessary user refresh after deletion can cause permission error
    
    obj.refresh_all() was being called no matter what. It needs to be called only when
    there is an issue deleting the patron. On success, this patch will simply present an
    informational message to the user.
    
    Signed-off-by: blake <blake at mobiusconsortium.org>
    Signed-off-by: Jason Etheridge <jason at esilibrary.com>

diff --git a/Open-ILS/xul/staff_client/server/locale/en-US/patron.properties b/Open-ILS/xul/staff_client/server/locale/en-US/patron.properties
index 99c92b8..1d3b68e 100644
--- a/Open-ILS/xul/staff_client/server/locale/en-US/patron.properties
+++ b/Open-ILS/xul/staff_client/server/locale/en-US/patron.properties
@@ -108,6 +108,7 @@ staff.patron.display.cmd_patron_delete.dest_user.title=Destination User
 staff.patron.display.cmd_patron_delete.dest_user.failure=Failed to retrieve destination user.  User deletion aborted.
 staff.patron.display.cmd_patron_delete.dest_user.self_reference_failure=Cannot specify the deleted user as the destination user.  User deletion aborted.
 staff.patron.display.cmd_patron_delete.override_prompt=Override patron deletion failure?
+staff.patron.display.cmd_patron_delete.success_message=Patron deleted. Please close tab.
 staff.patron.display.spawn_editor.editing_related_patron=Editing Related Patron
 staff.patron.display.init.retrieving_patron=Retrieving Patron...
 staff.patron.display.init.retrieving=Retrieving...
diff --git a/Open-ILS/xul/staff_client/server/patron/display.js b/Open-ILS/xul/staff_client/server/patron/display.js
index 7eaca57..04a9dd7 100644
--- a/Open-ILS/xul/staff_client/server/patron/display.js
+++ b/Open-ILS/xul/staff_client/server/patron/display.js
@@ -142,8 +142,11 @@ patron.display.prototype = {
                                                 return;
                                             break;
                                         }
+                                        obj.refresh_all();
+                                    }
+                                    else {
+                                        alert( document.getElementById('patronStrings').getString('staff.patron.display.cmd_patron_delete.success_message') );
                                     }
-                                    obj.refresh_all();
                                 }
                             } catch(E) {
                                 obj.error.standard_unexpected_error_alert('Error in server/patron/display.js -> cmd_patron_delete: ',E);

-----------------------------------------------------------------------

Summary of changes:
 .../server/locale/en-US/patron.properties          |    1 +
 Open-ILS/xul/staff_client/server/patron/display.js |    5 ++++-
 2 files changed, 5 insertions(+), 1 deletions(-)


hooks/post-receive
-- 
Evergreen ILS