[open-ils-commits] [GIT] Evergreen ILS branch master updated. 956432ce699f8da594f28b60fbc42a5d592fd1a6

[Evergreen Git]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Evergreen ILS".

The branch, master has been updated
       via  956432ce699f8da594f28b60fbc42a5d592fd1a6 (commit)
      from  238dba987ce2fb111682d94c02e11f1635fb60e1 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 956432ce699f8da594f28b60fbc42a5d592fd1a6
Author: Jason Etheridge <jason at esilibrary.com>
Date:   Wed Apr 26 17:23:26 2017 -0400

    LP#1491875: avoid erroneous "unsaved data" popup during MARC record creation
    
    Test plan
    ---------
    [1] Navigate to Cataloging -> Create New MARC Record.
    [2] Choose a template, click Load
    [3] Enter data in a fixed field, for example, Date1
    [4] Enter data in a MARC field such as 100
    [5] Click Create Record:
    
        The "This tab may have unsaved data. ..." pop up will appear.
        Clicking OK will save the record and take the user to their default
        view of the record.
        Clicking Cancel will save the record and return the user to the MARC
        Edit screen.
        The behavior when clicking Cancel can lead to confusion as to
        whether the record has actually been saved.
    
    [6] Apply the patch and repeats steps #1-#5.
    [7] This time, no extraneous unsaved data warning should appear.
    
    Note that this patch's kludge doesn't fix all possible instances
    of the warning; see https://bugs.launchpad.net/evergreen/+bug/1491875/comments/6
    for details.
    
    Signed-off-by: Jason Etheridge <jason at esilibrary.com>
    SIgned-off-by: Andrea Neiman <abneiman at equinoxinitiative.org>
    Signed-off-by: Galen Charlton <gmc at equinoxinitiative.org>

diff --git a/Open-ILS/xul/staff_client/server/cat/marcedit.js b/Open-ILS/xul/staff_client/server/cat/marcedit.js
index dca52a6..68bf3a3 100644
--- a/Open-ILS/xul/staff_client/server/cat/marcedit.js
+++ b/Open-ILS/xul/staff_client/server/cat/marcedit.js
@@ -1242,6 +1242,7 @@ function save_attempt(xml_string) {
                 tab.marc_edit_changed = false;
             }
             oils_unlock_page();
+            oils_unlock_page(); /* kludge for LP1491875 */
             if (result.id) {
                 replace_on_complete = fastItemAdd_attempt(result.id);
             }

-----------------------------------------------------------------------

Summary of changes:
 Open-ILS/xul/staff_client/server/cat/marcedit.js |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)


hooks/post-receive
-- 
Evergreen ILS