[open-ils-commits] [GIT] Evergreen ILS branch rel_2_12 updated. a1f3cc9b8db9a0c680c2cb94a5612fda120bb5ed

[Evergreen Git]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Evergreen ILS".

The branch, rel_2_12 has been updated
       via  a1f3cc9b8db9a0c680c2cb94a5612fda120bb5ed (commit)
       via  254e42e1f843a18d71f34a92986502cdcd450e0e (commit)
      from  a4add9ca465974bc775c5076c8543f96c37f55f5 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit a1f3cc9b8db9a0c680c2cb94a5612fda120bb5ed
Author: Galen Charlton <gmc at equinoxinitiative.org>
Date:   Thu May 18 21:59:28 2017 -0400

    LP#1610246: add upgrade note
    
    Signed-off-by: Galen Charlton <gmc at equinoxinitiative.org>

diff --git a/docs/RELEASE_NOTES_NEXT/Reports/fix_classic_current_circ.adoc b/docs/RELEASE_NOTES_NEXT/Reports/fix_classic_current_circ.adoc
new file mode 100644
index 0000000..7a59e98
--- /dev/null
+++ b/docs/RELEASE_NOTES_NEXT/Reports/fix_classic_current_circ.adoc
@@ -0,0 +1,7 @@
+Fix to reporter.classic_current_circ view
+^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
+The `reporter.classic_current_circ` view, which is part of some
+extra views defined in `Open-ILS/src/sql/Pg/example.reporter-extension.sql`,
+has been fixed to not exclude loans for patrons who do not have a
+billing address set. Users of this view should rerun
+`Open-ILS/src/sql/Pg/example.reporter-extension.sql` during upgrade.

commit 254e42e1f843a18d71f34a92986502cdcd450e0e
Author: Chris Sharp <csharp at georgialibraries.org>
Date:   Fri Aug 5 09:27:23 2016 -0400

    LP#1610246 Classic Circulation View excluding circulations
    
    The reporter.classic_current_circ view, which is available via
    Open-ILS/src/sql/Pg/example.reporter-extension.sql, was excluding
    circulations because it was assuming all users have a billing address
    This branch corrects that with a LEFT JOIN.
    
    No upgrade script will be included since these views are not assumed
    to be installed by all Evergreen instances.  Please re-run the
    example.reporter-extension.sql file to apply this change for your
    instance.
    
    Signed-off-by: Chris Sharp <csharp at georgialibraries.org>
    Signed-off-by: Galen Charlton <gmc at equinoxinitiative.org>

diff --git a/Open-ILS/src/sql/Pg/example.reporter-extension.sql b/Open-ILS/src/sql/Pg/example.reporter-extension.sql
index 5095aee..8cee578 100644
--- a/Open-ILS/src/sql/Pg/example.reporter-extension.sql
+++ b/Open-ILS/src/sql/Pg/example.reporter-extension.sql
@@ -110,7 +110,7 @@ SELECT	cl.shortname AS circ_lib,
 	JOIN actor.org_unit hl ON (p.home_ou = hl.id)
 	JOIN permission.grp_tree g ON (p.profile = g.id)
 	JOIN reporter.demographic dem ON (dem.id = p.id)
-	JOIN actor.usr_address paddr ON (paddr.id = p.billing_address)
+	LEFT JOIN actor.usr_address paddr ON (paddr.id = p.billing_address)
 	LEFT JOIN config.language_map lm ON (rd.item_lang = lm.code)
 	LEFT JOIN config.lit_form_map lfm ON (rd.lit_form = lfm.code)
 	LEFT JOIN config.item_form_map ifm ON (rd.item_form = ifm.code)

-----------------------------------------------------------------------

Summary of changes:
 Open-ILS/src/sql/Pg/example.reporter-extension.sql |    2 +-
 .../Reports/fix_classic_current_circ.adoc          |    7 +++++++
 2 files changed, 8 insertions(+), 1 deletions(-)
 create mode 100644 docs/RELEASE_NOTES_NEXT/Reports/fix_classic_current_circ.adoc


hooks/post-receive
-- 
Evergreen ILS