[open-ils-commits] [GIT] Evergreen ILS branch rel_3_0 updated. 14a567ab209c4d7e95dcde5b334fd8a71fba23bf

Evergreen Git git at git.evergreen-ils.org
Fri Nov 10 12:16:57 EST 2017


This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Evergreen ILS".

The branch, rel_3_0 has been updated
       via  14a567ab209c4d7e95dcde5b334fd8a71fba23bf (commit)
      from  f26c0af05900f3457a69b23dffb5ccfe3630f4cc (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 14a567ab209c4d7e95dcde5b334fd8a71fba23bf
Author: Bill Erickson <berickxx at gmail.com>
Date:   Thu Nov 9 11:39:12 2017 -0500

    LP#1731496 Avoid PhantomJS BroadcastChannel failure
    
    Avoid attempts to create BroadcastChannel objects in contexts where the
    object does not exist.  Specifically, allow PhantomJS to run unit tesst
    without dying on:
    
    ReferenceError: Can't find variable: BroadcastChannel
    
    Signed-off-by: Bill Erickson <berickxx at gmail.com>
    Signed-off-by: Chris Sharp <csharp at georgialibraries.org>

diff --git a/Open-ILS/web/js/ui/default/staff/services/auth.js b/Open-ILS/web/js/ui/default/staff/services/auth.js
index 8912c78..ec83005 100644
--- a/Open-ILS/web/js/ui/default/staff/services/auth.js
+++ b/Open-ILS/web/js/ui/default/staff/services/auth.js
@@ -53,7 +53,10 @@ function($q , $timeout , $rootScope , $window , $location , egNet , egHatch) {
         },
 
         // Listen for logout events in other tabs
-        authChannel : new BroadcastChannel('eg.auth')
+        // Current version of phantomjs (unit tests, etc.) does not 
+        // support BroadcastChannel, so just dummy it up.
+        authChannel : (typeof BroadcastChannel == 'undefined') ? 
+            {} : new BroadcastChannel('eg.auth')
     };
 
     /* Returns a promise, which is resolved if valid

-----------------------------------------------------------------------

Summary of changes:
 Open-ILS/web/js/ui/default/staff/services/auth.js |    5 ++++-
 1 files changed, 4 insertions(+), 1 deletions(-)


hooks/post-receive
-- 
Evergreen ILS


More information about the open-ils-commits mailing list