[open-ils-commits] [GIT] Evergreen ILS branch master updated. b9a637829cf5c4690e6a5ab7cc149d4d11e72897

[Evergreen Git]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Evergreen ILS".

The branch, master has been updated
       via  b9a637829cf5c4690e6a5ab7cc149d4d11e72897 (commit)
      from  61d6e6c1ebdb329629bed2e07fa0ac73873a02a3 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit b9a637829cf5c4690e6a5ab7cc149d4d11e72897
Author: Mike Rylander <mrylander at gmail.com>
Date:   Mon Apr 2 16:09:12 2018 -0400

    LP#1760223: Update HTTP headers to follow standard
    
    In the olden days, some browsers didn't understand the "attachment" content
    disposition.  They only understood "inline" but would let the user save a file
    if a filename was provided.  However, in these modern days, relevant browsers
    all do the right thing and know about both flavors of content disposition, so
    we, too, must change with the times and support the letter of the standard.
    
    This commit fixes downloading of MARCXML from the Exporter module.
    
    Signed-off-by: Mike Rylander <mrylander at gmail.com>
    Signed-off-by: Jane Sandberg <sandbej at linnbenton.edu>
    Signed-off-by: Cesar Velez <cesar.velez at equinoxinitiative.org>
    Signed-off-by: Galen Charlton <gmc at equinoxinitiative.org>

diff --git a/Open-ILS/src/perlmods/lib/OpenILS/WWW/Exporter.pm b/Open-ILS/src/perlmods/lib/OpenILS/WWW/Exporter.pm
index bf2fa36..8508ab6 100644
--- a/Open-ILS/src/perlmods/lib/OpenILS/WWW/Exporter.pm
+++ b/Open-ILS/src/perlmods/lib/OpenILS/WWW/Exporter.pm
@@ -180,7 +180,7 @@ sub handler {
     }
 
 
-    $r->headers_out->set("Content-Disposition" => "inline; filename=$filename");
+    $r->headers_out->set("Content-Disposition" => "attachment; filename=$filename");
 
     if (uc($format) eq 'XML') {
         $r->content_type('application/xml');

-----------------------------------------------------------------------

Summary of changes:
 Open-ILS/src/perlmods/lib/OpenILS/WWW/Exporter.pm |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)


hooks/post-receive
-- 
Evergreen ILS