[open-ils-commits] [GIT] Evergreen ILS branch rel_3_0 updated. 4effe3c63f29332a6b3a29ad568675217c538172
Evergreen Git
git at git.evergreen-ils.org
Wed Aug 22 11:09:48 EDT 2018
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Evergreen ILS".
The branch, rel_3_0 has been updated
via 4effe3c63f29332a6b3a29ad568675217c538172 (commit)
from e623229de0b8c3c2372ead4b0f722decfcc18c33 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit 4effe3c63f29332a6b3a29ad568675217c538172
Author: Bill Erickson <berickxx at gmail.com>
Date: Fri Aug 10 12:16:57 2018 -0400
LP#1724029 Patron search API returns correct order
Avoid use of max_chunk_size in patron search API as it results in
streaming responses in the wrong order. Use max_bundle_count instead,
which does not suffer from the sorting issues. What's more, its purpose
and affect is easier to grasp in the code.
Bundle count is set to 5 so the API will begin returning results at most
5 patrons into the data fleshing process.
Signed-off-by: Bill Erickson <berickxx at gmail.com>
Signed-off-by: Michele Morgan <mmorgan at noblenet.org>
diff --git a/Open-ILS/src/perlmods/lib/OpenILS/Application/Actor.pm b/Open-ILS/src/perlmods/lib/OpenILS/Application/Actor.pm
index 4c11c82..c037544 100644
--- a/Open-ILS/src/perlmods/lib/OpenILS/Application/Actor.pm
+++ b/Open-ILS/src/perlmods/lib/OpenILS/Application/Actor.pm
@@ -1322,16 +1322,8 @@ __PACKAGE__->register_method(
method => "patron_adv_search",
api_name => "open-ils.actor.patron.search.advanced.fleshed",
stream => 1,
- # TODO: change when opensrf 'bundling' is merged.
- # set a relatively small bundle size so the caller can start
- # seeing results fairly quickly
- max_chunk_size => 4096, # bundling
-
- # api_level => 2,
- # pending opensrf work -- also, not sure if needed since we're not
- # actaully creating an alternate vesrion, only offering to return a
- # different format.
- #
+ # Flush the response stream at most 5 patrons in for UI responsiveness.
+ max_bundle_count => 5,
signature => {
desc => q/Returns a stream of fleshed user objects instead of
a pile of identifiers/
-----------------------------------------------------------------------
Summary of changes:
.../src/perlmods/lib/OpenILS/Application/Actor.pm | 12 ++----------
1 files changed, 2 insertions(+), 10 deletions(-)
hooks/post-receive
--
Evergreen ILS
More information about the open-ils-commits
mailing list