[open-ils-commits] [GIT] Evergreen ILS branch master updated. 56bcda57b3d8a364abc883afe9e27563bef8f6cd

[Evergreen Git]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Evergreen ILS".

The branch, master has been updated
       via  56bcda57b3d8a364abc883afe9e27563bef8f6cd (commit)
      from  d90f69feb04cb1ebf345a2f7457d2a4886cdf9e6 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 56bcda57b3d8a364abc883afe9e27563bef8f6cd
Author: Kyle Huckins <khuckins at catalyte.io>
Date:   Thu Jan 11 18:10:51 2018 +0000

    lp1742194 - Print Current Bills only printing circ bills
    
    - Check xact for Circulation before assigning circulation data to
    xact for printing.
    
    To test
    -------
    [1] Set up a patron with at least one "grocery" bill.
    [2] In the web staff client, go to
        Patron Account > Bills > Actions > Print Bills
    [3] Note that the current bills summary is not printed
        and that there an error in the browser console.
    [4] Apply the patch and repeat step #2. This time, the
        bills summary should be printed.
    
    Signed-off-by: Kyle Huckins <khuckins at catalyte.io>
    Signed-off-by: Terra McCanna <tmccanna at georgialibraries.org>
    Signed-off-by: Galen Charlton <gmc at equinoxinitiative.org>

diff --git a/Open-ILS/web/js/ui/default/staff/circ/patron/bills.js b/Open-ILS/web/js/ui/default/staff/circ/patron/bills.js
index ce240f9..46fc0b9 100644
--- a/Open-ILS/web/js/ui/default/staff/circ/patron/bills.js
+++ b/Open-ILS/web/js/ui/default/staff/circ/patron/bills.js
@@ -498,8 +498,10 @@ function($scope , $q , $routeParams , egCore , egConfirmDialog , $location,
                     unrecovered : xact.unrecovered(),
                     xact_finish : xact.xact_finish(),
                     xact_start : xact.xact_start(),
-                    copy_barcode : xact.circulation().target_copy().barcode(),
-                    title : xact.circulation().target_copy().call_number().record().simple_record().title()
+                }
+                if (xact.circulation()) {
+                    newXact.copy_barcode = xact.circulation().target_copy().barcode(),
+                    newXact.title = xact.circulation().target_copy().call_number().record().simple_record().title()
                 }
                 xacts.push(newXact);
             }
@@ -963,8 +965,10 @@ function($scope,  $q , egCore , patronSvc , billSvc , egPromptDialog , $location
                     unrecovered : xact.unrecovered(),
                     xact_finish : xact.xact_finish(),
                     xact_start : xact.xact_start(),
-                    copy_barcode : xact.circulation().target_copy().barcode(),
-                    title : xact.circulation().target_copy().call_number().record().simple_record().title()
+                }
+                if (xact.circulation()) {
+                    newXact.copy_barcode = xact.circulation().target_copy().barcode(),
+                    newXact.title = xact.circulation().target_copy().call_number().record().simple_record().title()
                 }
                 xacts.push(newXact);
             }

-----------------------------------------------------------------------

Summary of changes:
 .../web/js/ui/default/staff/circ/patron/bills.js   |   12 ++++++++----
 1 files changed, 8 insertions(+), 4 deletions(-)


hooks/post-receive
-- 
Evergreen ILS