[open-ils-commits] [GIT] Evergreen ILS branch master updated. f299eb2bfedef9eab7e1655686b6044027437788

[Evergreen Git]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Evergreen ILS".

The branch, master has been updated
       via  f299eb2bfedef9eab7e1655686b6044027437788 (commit)
      from  d66db64780067fa8acf86f5392c592c369325bfd (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit f299eb2bfedef9eab7e1655686b6044027437788
Author: Michele Morgan <mmorgan at noblenet.org>
Date:   Thu Sep 14 11:48:31 2017 -0400

    LP#1692116 - Action trigger validator fix for paid Long Overdue items
    
    Adds a check for a NULL xact_finish to the CircIsOpen validator. The
    result is that overdue notification a/t events for Long Overdue items that
    have been paid for, and the transaction closed, will be invalid.
    
    Signed-off-by: Michele Morgan <mmorgan at noblenet.org>
    Signed-off-by: Chris Sharp <csharp at georgialibraries.org>

diff --git a/Open-ILS/src/perlmods/lib/OpenILS/Application/Trigger/Validator.pm b/Open-ILS/src/perlmods/lib/OpenILS/Application/Trigger/Validator.pm
index db909a5..1a53dfb 100644
--- a/Open-ILS/src/perlmods/lib/OpenILS/Application/Trigger/Validator.pm
+++ b/Open-ILS/src/perlmods/lib/OpenILS/Application/Trigger/Validator.pm
@@ -18,6 +18,7 @@ sub CircIsOpen {
     my $env = shift;
 
     return 0 if (defined($env->{target}->checkin_time));
+    return 0 if (defined($env->{target}->xact_finish));
 
     if ($env->{params}->{min_target_age}) {
         $env->{params}->{target_age_field} = 'xact_start';

-----------------------------------------------------------------------

Summary of changes:
 .../lib/OpenILS/Application/Trigger/Validator.pm   |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)


hooks/post-receive
-- 
Evergreen ILS