[open-ils-commits] [GIT] Evergreen ILS branch rel_3_0 updated. e285e4baa9fd39f9acb1b5fc722cd3736ec696e9

[Evergreen Git]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Evergreen ILS".

The branch, rel_3_0 has been updated
       via  e285e4baa9fd39f9acb1b5fc722cd3736ec696e9 (commit)
      from  dcb1bc27741ffeb7303a657af02a772a52c0cb2f (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit e285e4baa9fd39f9acb1b5fc722cd3736ec696e9
Author: Remington Steed <rjs7 at calvin.edu>
Date:   Wed Feb 7 14:41:47 2018 -0500

    LP#1747963 Fix "trim list" feature in web client
    
    The use of splice() here caused buggy behavior and seemed to be a typo,
    so I tried using slice() instead. But that still didn't work correctly.
    The list stopped adding items after it reached 21 total, so scanning a
    new barcode didn't add it to the list but only refreshed the list.
    
    Instead, this commit sets the length of the array to 20, which shortens
    the array as described in the MDN documentation for Array.length. Now it
    behaves like it did in the XUL client.
    
    Signed-off-by: Remington Steed <rjs7 at calvin.edu>
    Signed-off-by: Cesar Velez <cesar.velez at equinoxinitiative.org>
    Signed-off-by: Bill Erickson <berickxx at gmail.com>

diff --git a/Open-ILS/web/js/ui/default/staff/circ/checkin/app.js b/Open-ILS/web/js/ui/default/staff/circ/checkin/app.js
index 516e43f..5076140 100644
--- a/Open-ILS/web/js/ui/default/staff/circ/checkin/app.js
+++ b/Open-ILS/web/js/ui/default/staff/circ/checkin/app.js
@@ -217,7 +217,8 @@ function($scope , $q , $window , $location , $timeout , egCore , checkinSvc , eg
             }
 
             if ($scope.trim_list && checkinSvc.checkins.length > 20)
-                checkinSvc.checkins = checkinSvc.checkins.splice(0, 20);
+                //cut array short at 20 items
+                checkinSvc.checkins.length = 20;
         },
         function() {
             // Checkin was rejected somewhere along the way.

-----------------------------------------------------------------------

Summary of changes:
 .../web/js/ui/default/staff/circ/checkin/app.js    |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)


hooks/post-receive
-- 
Evergreen ILS