[open-ils-commits] [GIT] Evergreen ILS branch master updated. 3f762988042021aaa31a646759055f226d58e777

[Evergreen Git]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Evergreen ILS".

The branch, master has been updated
       via  3f762988042021aaa31a646759055f226d58e777 (commit)
      from  f265176d550758f6a6c564709b97114d9758c44f (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 3f762988042021aaa31a646759055f226d58e777
Author: Bill Erickson <berickxx at gmail.com>
Date:   Tue May 15 16:12:12 2018 -0400

    LP#1771422 Reset transiting hold copy status fix
    
    Avoid modifying the copy status in the hold-reset API when it's passing
    the copy off to the transit API for canceling the transit.  Let the
    transit API handle the status instead.
    
    This fixes a bug where resetting a transiting hold, and canceling its
    transit, would leave the targeted copy in "in transit" status instead of
    "canceled transit".
    
    Signed-off-by: Bill Erickson <berickxx at gmail.com>
    Signed-off-by: Garry Collum <gcollum at gmail.com>
    Signed-off-by: Galen Charlton <gmc at equinoxinitiative.org>

diff --git a/Open-ILS/src/perlmods/lib/OpenILS/Application/Circ/Holds.pm b/Open-ILS/src/perlmods/lib/OpenILS/Application/Circ/Holds.pm
index 350fde2..b15de7c 100644
--- a/Open-ILS/src/perlmods/lib/OpenILS/Application/Circ/Holds.pm
+++ b/Open-ILS/src/perlmods/lib/OpenILS/Application/Circ/Holds.pm
@@ -1978,8 +1978,6 @@ sub _reset_hold {
 
         } elsif( $copy->status == OILS_COPY_STATUS_IN_TRANSIT ) {
 
-            # We don't want the copy to remain "in transit"
-            $copy->status(OILS_COPY_STATUS_RESHELVING);
             $logger->warn("! reseting hold [$hid] that is in transit");
             my $transid = $e->search_action_hold_transit_copy({hold=>$hold->id,cancel_time=>undef},{idlist=>1})->[0];
 

-----------------------------------------------------------------------

Summary of changes:
 .../perlmods/lib/OpenILS/Application/Circ/Holds.pm |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)


hooks/post-receive
-- 
Evergreen ILS