[open-ils-commits] [GIT] Evergreen ILS branch master updated. 4773b3e92414c334475d48523475d24f98ef7510

Evergreen Git git at git.evergreen-ils.org
Fri May 25 16:45:50 EDT 2018


This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Evergreen ILS".

The branch, master has been updated
       via  4773b3e92414c334475d48523475d24f98ef7510 (commit)
       via  7bf929c46bdbce5b02a7adbafaf3939e48889d5c (commit)
      from  215413b50c42b05192fd266495dd7dce6654c642 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 4773b3e92414c334475d48523475d24f98ef7510
Author: Kathy Lussier <klussier at masslnc.org>
Date:   Fri May 25 16:44:26 2018 -0400

    Docs: Add release note for bug 1707063
    
    Signed-off-by: Kathy Lussier <klussier at masslnc.org>

diff --git a/docs/RELEASE_NOTES_3_1.adoc b/docs/RELEASE_NOTES_3_1.adoc
index 25ed968..ee17573 100644
--- a/docs/RELEASE_NOTES_3_1.adoc
+++ b/docs/RELEASE_NOTES_3_1.adoc
@@ -132,6 +132,8 @@ AngularJS versions (such as 1.7) from breaking the build process.
 * Adds some padding to the bottom of Web Client interfaces.
 * Logins now honor all org unit timeout settings.
 * Evergreen will now identify and handle invalid timezones.
+* Fixes an issue where a column header in some interfaces were automatically
+highlighted in green when retrieving the interface.
 
 
 Acknowledgements

commit 7bf929c46bdbce5b02a7adbafaf3939e48889d5c
Author: Mike Rylander <mrylander at gmail.com>
Date:   Mon Jan 29 16:37:15 2018 -0500

    LP#1707063: Naive ng-class test for last-column-modified
    
    Instead of comparing a (potentially undefined) property of a column, we'll
    just compare the column object directly when checking to see if a column
    header should be highlighted for "last touched in editing mode."
    
    Signed-off-by: Mike Rylander <mrylander at gmail.com>
    Signed-off-by: Cesar Velez <cesar.velez at equinoxinitiative.org>
    Signed-off-by: Kathy Lussier <klussier at masslnc.org>

diff --git a/Open-ILS/src/templates/staff/share/t_autogrid.tt2 b/Open-ILS/src/templates/staff/share/t_autogrid.tt2
index 4a91d0c..0519012 100644
--- a/Open-ILS/src/templates/staff/share/t_autogrid.tt2
+++ b/Open-ILS/src/templates/staff/share/t_autogrid.tt2
@@ -230,7 +230,7 @@
     </div>
     <div class="eg-grid-cell"
         eg-grid-column-drag-dest
-        ng-class="{'eg-grid-column-last-mod' : lastModColumn==col.name}"
+        ng-class="{'eg-grid-column-last-mod' : isLastModifiedColumn(col)}"
         column="{{col.name}}"
         eg-right-click="onContextMenu($event)"
         ng-repeat="col in columns"
diff --git a/Open-ILS/web/js/ui/default/staff/services/grid.js b/Open-ILS/web/js/ui/default/staff/services/grid.js
index fc3a05b..15d61f2 100644
--- a/Open-ILS/web/js/ui/default/staff/services/grid.js
+++ b/Open-ILS/web/js/ui/default/staff/services/grid.js
@@ -765,10 +765,16 @@ angular.module('egGridMod',
                     column.flex = 1;
             }
             $scope.modifyColumnFlex = function(col, val) {
-                $scope.lastModColumn = col.name;
+                $scope.lastModColumn = col;
                 grid.modifyColumnFlex(col, val);
             }
 
+            $scope.isLastModifiedColumn = function(col) {
+                if ($scope.lastModColumn)
+                    return $scope.lastModColumn === col;
+                return false;
+            }
+
             grid.modifyColumnPos = function(col, diff) {
                 var srcIdx, targetIdx;
                 angular.forEach(grid.columnsProvider.columns,
@@ -801,7 +807,7 @@ angular.module('egGridMod',
             }
 
             $scope.modifyColumnPos = function(col, diff) {
-                $scope.lastModColumn = col.name;
+                $scope.lastModColumn = col;
                 return grid.modifyColumnPos(col, diff);
             }
 

-----------------------------------------------------------------------

Summary of changes:
 Open-ILS/src/templates/staff/share/t_autogrid.tt2 |    2 +-
 Open-ILS/web/js/ui/default/staff/services/grid.js |   10 ++++++++--
 docs/RELEASE_NOTES_3_1.adoc                       |    2 ++
 3 files changed, 11 insertions(+), 3 deletions(-)


hooks/post-receive
-- 
Evergreen ILS


More information about the open-ils-commits mailing list