[open-ils-commits] [GIT] Evergreen ILS branch master updated. 76de5680b0404117a2e4a9a741217236213c534a

Evergreen Git git at git.evergreen-ils.org
Tue Nov 6 09:54:07 EST 2018


This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Evergreen ILS".

The branch, master has been updated
       via  76de5680b0404117a2e4a9a741217236213c534a (commit)
       via  5a39effec62f7a901a5c24df6b4a4c810fa6e7d2 (commit)
      from  a17db632cfe5c42df49a49d3e0f631d1b03b4969 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 76de5680b0404117a2e4a9a741217236213c534a
Author: Kathy Lussier <klussier at masslnc.org>
Date:   Mon Nov 5 15:50:24 2018 -0500

    LP#1755543: Change placement of help popovers
    
    Set the placement of help tip popovers so that they automatically position
    to a visible place on the screen.
    
    Signed-off-by: Kathy Lussier <klussier at masslnc.org>
    Signed-off-by: Remington Steed <rjs7 at calvin.edu>
    Signed-off-by: Galen Charlton <gmc at equinoxinitiative.org>

diff --git a/Open-ILS/src/templates/staff/share/t_help_popover.tt2 b/Open-ILS/src/templates/staff/share/t_help_popover.tt2
index 215400a..c07ee20 100644
--- a/Open-ILS/src/templates/staff/share/t_help_popover.tt2
+++ b/Open-ILS/src/templates/staff/share/t_help_popover.tt2
@@ -1,10 +1,12 @@
 <span class="glyphicon glyphicon-question-sign"
       uib-popover="{{helpText}}"
       popover-trigger="click"
+      popover-placement="auto"
       ng-if="!helpLink || helpLink.length == 0"
 ></span>
 <span class="glyphicon glyphicon-question-sign"
       uib-popover-html="helpHtml"
       popover-trigger="click"
+      popover-placement="auto"
       ng-if="helpLink.length > 0"
 ></span>

commit 5a39effec62f7a901a5c24df6b4a4c810fa6e7d2
Author: Kathy Lussier <klussier at masslnc.org>
Date:   Tue Mar 13 12:54:42 2018 -0400

    LP#1755543: Add help tips to Print Item Labels Settings tab
    
    Instead of providing lengthy settings descriptions, which result in a lot of
    scrolling on the Print Item Template page, let's use help tips that can
    provide guidance to new users without adding clutter to the interface.
    
    This commit also turns the field labels into HTML labels for improved
    accessibility and removes borders on the page. The borders were helpful
    when we displayed the help text on the page, but are no longer needed.
    
    Signed-off-by: Kathy Lussier <klussier at masslnc.org>
    Signed-off-by: Remington Steed <rjs7 at calvin.edu>
    Signed-off-by: Galen Charlton <gmc at equinoxinitiative.org>

diff --git a/Open-ILS/src/templates/staff/cat/printlabels/t_view.tt2 b/Open-ILS/src/templates/staff/cat/printlabels/t_view.tt2
index 49f82dc..fc5dfed 100644
--- a/Open-ILS/src/templates/staff/cat/printlabels/t_view.tt2
+++ b/Open-ILS/src/templates/staff/cat/printlabels/t_view.tt2
@@ -126,14 +126,10 @@
             <div ng-show="current_tab == 'settings'">
                 <div><span>[% l('These settings do get saved with templates and will override corresponding Library Settings.') %]<br/></span></div>
                 <div ng-repeat="s in org_unit_settings">
-                    <div class="row" style="margin-top: 5mm; border-top: solid thin black">
-                        <div class="col-md-6" style="font-weight: bold">{{s.label}}</div>
+                    <div class="row" style="margin-top: 5mm;">
+                        <div class="col-md-6"><label>{{s.label}} <eg-help-popover help-text="{{s.description}}"></label></div>
                         <div class="col-md-6"><input type="text" ng-model="preview_scope.settings[s.name]"></input></div>
                     </div>
-
-                    <div class="row">
-                        <div>{{s.description}}</div>
-                    </div>
                 </div>
 
             </div>

-----------------------------------------------------------------------

Summary of changes:
 .../src/templates/staff/cat/printlabels/t_view.tt2 |    8 ++------
 .../src/templates/staff/share/t_help_popover.tt2   |    2 ++
 2 files changed, 4 insertions(+), 6 deletions(-)


hooks/post-receive
-- 
Evergreen ILS


More information about the open-ils-commits mailing list