[open-ils-commits] [GIT] Evergreen ILS branch master updated. 65f5afc47e9ed0d3006eeba963c6c7057479cdae

[Evergreen Git]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Evergreen ILS".

The branch, master has been updated
       via  65f5afc47e9ed0d3006eeba963c6c7057479cdae (commit)
      from  f594e2854a172ad61a5a27eaf3804d42a4a07020 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 65f5afc47e9ed0d3006eeba963c6c7057479cdae
Author: Galen Charlton <gmc at equinoxinitiative.org>
Date:   Thu Sep 13 14:25:05 2018 -0400

    LP#1792429: calculate queue position in correct order
    
    This patch ensures that the relative hold queue position
    displayed in the webstaff Hold Shelf and Record -> View Holds
    interfaces is calculated in the correct order, i.e., (cut-in-line aside)
    with holds requested earlier having a lower queue position than
    holds requested later.
    
    To test
    -------
    [1] Set up a bib with a number of hold requests.
    [2] Under Record -> Viwe Holds, note that the queue
        positions are reversed, with later holds having lower
        queue positions.
    [3] Apply the patch and repeat step #2. This time, the queue
        positions should be correct.
    
    Signed-off-by: Galen Charlton <gmc at equinoxinitiative.org>
    Signed-off-by: Bill Erickson <berickxx at gmail.com>

diff --git a/Open-ILS/src/perlmods/lib/OpenILS/Application/Storage/Publisher/action.pm b/Open-ILS/src/perlmods/lib/OpenILS/Application/Storage/Publisher/action.pm
index 238746c..3c69f33 100644
--- a/Open-ILS/src/perlmods/lib/OpenILS/Application/Storage/Publisher/action.pm
+++ b/Open-ILS/src/perlmods/lib/OpenILS/Application/Storage/Publisher/action.pm
@@ -2302,7 +2302,7 @@ SELECT  h.id, h.request_time, h.capture_time, h.fulfillment_time, h.checkin_time
 
         ROW_NUMBER() OVER (
             PARTITION BY r.bib_record
-            ORDER BY h.cut_in_line DESC NULLS LAST, h.request_time DESC
+            ORDER BY h.cut_in_line DESC NULLS LAST, h.request_time ASC
         ) AS relative_queue_position,
 
         EXTRACT(EPOCH FROM COALESCE(

-----------------------------------------------------------------------

Summary of changes:
 .../Application/Storage/Publisher/action.pm        |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)


hooks/post-receive
-- 
Evergreen ILS