[open-ils-commits] [GIT] Evergreen ILS branch master updated. e83a8c001a66ba7378c79c8ccd4451aeb711b956

[Evergreen Git]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Evergreen ILS".

The branch, master has been updated
       via  e83a8c001a66ba7378c79c8ccd4451aeb711b956 (commit)
      from  7f08fdb4988ec1edf06ebbbf0fb1b32178292155 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit e83a8c001a66ba7378c79c8ccd4451aeb711b956
Author: Galen Charlton <gmc at equinoxinitiative.org>
Date:   Fri Apr 19 17:20:42 2019 -0400

    LP#1825578: reverse direction of sort-order arrows in eg-grid
    
    This patch adjusts the arrow icons used to indicate if a column
    in the Angular eg-grid is sorted to use the following convention:
    
      sort order ascending == display _up_ arrow
      sort order descending == display _descending_ arrow
    
    To test
    -------
    [1] Apply the patch.
    [2] In a grid with a sortable column (as can be found in /eg2/en-US/staff/sandbox),
        click on the heading to sort it. Verify that ascending sort displays
        the upwards arrow and descending sort the downwards.
    
    Signed-off-by: Galen Charlton <gmc at equinoxinitiative.org>
    Signed-off-by: Bill Erickson <berickxx at gmail.com>
    Signed-off-by: Galen Charlton <gmc at equinoxinitiative.org>

diff --git a/Open-ILS/src/eg2/src/app/share/grid/grid-header.component.html b/Open-ILS/src/eg2/src/app/share/grid/grid-header.component.html
index 0662f54b0b..98a6fbf365 100644
--- a/Open-ILS/src/eg2/src/app/share/grid/grid-header.component.html
+++ b/Open-ILS/src/eg2/src/app/share/grid/grid-header.component.html
@@ -24,9 +24,9 @@
       (click)="sortOneColumn(col)">
       <span class="eg-grid-header-cell-sort-label">{{col.label}}</span>
       <span class="material-icons eg-grid-header-cell-sort-arrow"
-        *ngIf="isColumnSorting(col, 'ASC')">arrow_downwards</span>
+        *ngIf="isColumnSorting(col, 'ASC')">arrow_upwards</span>
       <span class="material-icons eg-grid-header-cell-sort-arrow"
-        *ngIf="isColumnSorting(col, 'DESC')">arrow_upwards</span>
+        *ngIf="isColumnSorting(col, 'DESC')">arrow_downwards</span>
     </a>
     <span *ngIf="!col.isSortable">{{col.label}}</span>
   </div>

-----------------------------------------------------------------------

Summary of changes:
 Open-ILS/src/eg2/src/app/share/grid/grid-header.component.html | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)


hooks/post-receive
-- 
Evergreen ILS