[open-ils-commits] [GIT] Evergreen ILS branch rel_3_1 updated. ef56658890d278cc18f4fc679ea976ab042e5c2c

[Evergreen Git]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Evergreen ILS".

The branch, rel_3_1 has been updated
       via  ef56658890d278cc18f4fc679ea976ab042e5c2c (commit)
      from  80ca622d355d9a929dfcf96851c5845acb9758e8 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit ef56658890d278cc18f4fc679ea976ab042e5c2c
Author: Dan Briem <dbriem at wlsmail.org>
Date:   Fri Jul 5 19:34:13 2019 -0400

    LP#1805895 Bucket grid configuration updates do not save
    
    Some saved columns stick, but others are ignored. Issue affects eg-grid[s]
    that use the auto-fields attr to load all columns on idl-class attr. This
    is because saved columns are whitelisted against the initial column config
    before the auto fields are loaded.
    
    Patch adds $scope.handleAutoFields() to egCore.hatch.getItem. This happens
    after the eg-grid-fields transclude (no collisions) but before the saved
    columns are whitelisted. The original call remains to handle cases where
    there is no persist-key or saved config.
    
    Test:
    1. Go to Circulation->User Buckets
    2. Add the Is Deleted column to the grid
    3. Save columns and refresh (note Is Deleted is not visible)
    4. Apply patch and repeat steps 1-3 (note Is Deleted is now visible)
    
    Signed-off-by: Dan Briem <dbriem at wlsmail.org>
    Signed-off-by: Galen Charlton <gmc at equinoxinitiative.org>
    Signed-off-by: Jason Boyer <jboyer at library.in.gov>

diff --git a/Open-ILS/web/js/ui/default/staff/services/grid.js b/Open-ILS/web/js/ui/default/staff/services/grid.js
index ea2d61c004..cfd0688af7 100644
--- a/Open-ILS/web/js/ui/default/staff/services/grid.js
+++ b/Open-ILS/web/js/ui/default/staff/services/grid.js
@@ -474,6 +474,9 @@ angular.module('egGridMod',
                 .then(function(conf) {
                     if (!conf) return;
 
+                    // load all column options before validating saved columns
+                    $scope.handleAutoFields();
+
                     var columns = grid.columnsProvider.columns;
                     var new_cols = [];
 

-----------------------------------------------------------------------

Summary of changes:
 Open-ILS/web/js/ui/default/staff/services/grid.js | 3 +++
 1 file changed, 3 insertions(+)


hooks/post-receive
-- 
Evergreen ILS