[open-ils-commits] [GIT] Evergreen ILS branch master updated. 8403ec3095c79df46029ff16de05b39b0bb59a74

[Evergreen Git]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Evergreen ILS".

The branch, master has been updated
       via  8403ec3095c79df46029ff16de05b39b0bb59a74 (commit)
      from  aaff0777aef255cae35f1261fc2d2762ed565365 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 8403ec3095c79df46029ff16de05b39b0bb59a74
Author: Michele Morgan <mmorgan at noblenet.org>
Date:   Wed May 23 13:54:28 2018 -0400

    LP#1511765 Fix error when checking in with zero-balance lost OU setting enabled
    
    Fixes an error generated when checking in Lost/Long Overdue/Lost and Paid
    items with no associated circ when the org unit setting
    circ.checkin.lost_zero_balance.do_not_change is set to TRUE
    
    Items can attain this state from migration, or when the associated circ
    has been aged.
    
    Signed-off-by: Michele Morgan <mmorgan at noblenet.org>
    Signed-off-by: Kyle Huckins <khuckins at catalyte.io>
    Signed-off-by: Galen Charlton <gmc at equinoxinitiative.org>

diff --git a/Open-ILS/src/perlmods/lib/OpenILS/Application/Circ/Circulate.pm b/Open-ILS/src/perlmods/lib/OpenILS/Application/Circ/Circulate.pm
index 73d69efda6..7a2958a3ad 100644
--- a/Open-ILS/src/perlmods/lib/OpenILS/Application/Circ/Circulate.pm
+++ b/Open-ILS/src/perlmods/lib/OpenILS/Application/Circ/Circulate.pm
@@ -2678,7 +2678,8 @@ sub do_checkin {
             $copy_circ_lib, 'circ.checkin.lost_zero_balance.do_not_change',
             $self->editor) || 0;
 
-        if ($dont_change_lost_zero) {
+        # Don't assume there's always a circ based on copy status
+        if ($dont_change_lost_zero && $self->circ) {
             my ($obt) = $U->fetch_mbts($self->circ->id, $self->editor);
             $dont_change_lost_zero = 0 if( $obt and $obt->balance_owed != 0 );
         }

-----------------------------------------------------------------------

Summary of changes:
 Open-ILS/src/perlmods/lib/OpenILS/Application/Circ/Circulate.pm | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)


hooks/post-receive
-- 
Evergreen ILS