[open-ils-commits] [GIT] Evergreen ILS branch master updated. 4a67e5da99037ee815e135163c9523de7e897eae

[Evergreen Git]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Evergreen ILS".

The branch, master has been updated
       via  4a67e5da99037ee815e135163c9523de7e897eae (commit)
      from  92a6deff0e68152aca2fba917fb91767708b8445 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 4a67e5da99037ee815e135163c9523de7e897eae
Author: Galen Charlton <gmc at equinoxinitiative.org>
Date:   Fri Dec 27 11:04:32 2019 -0500

    LP#1827942: follow-up to fix a couple issues
    
    [1] Sets a default value for the modal options for dialogs such
        as ProgressDialog that do not supply any value for the
        options parameter; otherwise, progress dialogs would not
        appear at all.
    [2] Fix lint warnings.
    
    Signed-off-by: Galen Charlton <gmc at equinoxinitiative.org>

diff --git a/Open-ILS/src/eg2/src/app/share/dialog/dialog.component.ts b/Open-ILS/src/eg2/src/app/share/dialog/dialog.component.ts
index 27b611fb2f..866adec0a8 100644
--- a/Open-ILS/src/eg2/src/app/share/dialog/dialog.component.ts
+++ b/Open-ILS/src/eg2/src/app/share/dialog/dialog.component.ts
@@ -76,14 +76,16 @@ export class DialogComponent implements OnInit {
         this.onOpen$ = new EventEmitter<any>();
     }
 
-    open(options?: NgbModalOptions): Observable<any> {
+    open(options: NgbModalOptions = { backdrop: 'static' }): Observable<any> {
 
         if (this.modalRef !== null) {
             this.error('Dialog was replaced!');
             this.finalize();
         }
 
-        options.backdrop="static";
+        // force backdrop to static if caller passed in any options
+        options.backdrop = 'static';
+
         this.modalRef = this.modalService.open(this.dialogContent, options);
         DialogComponent.instances[this.identifier] = this;
 

-----------------------------------------------------------------------

Summary of changes:
 Open-ILS/src/eg2/src/app/share/dialog/dialog.component.ts | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)


hooks/post-receive
-- 
Evergreen ILS