[open-ils-commits] [GIT] Evergreen ILS branch rel_3_2 updated. 4b084b5149ce48ccfe0347e156602fb7d5e77c39

[Evergreen Git]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Evergreen ILS".

The branch, rel_3_2 has been updated
       via  4b084b5149ce48ccfe0347e156602fb7d5e77c39 (commit)
       via  ad10ddb1e690af8ae3a3049748972bb9873f7c50 (commit)
      from  4cb8b0af6fd220258b51701f428adcb13755afe3 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 4b084b5149ce48ccfe0347e156602fb7d5e77c39
Author: Jason Boyer <jboyer at library.in.gov>
Date:   Wed Jan 16 12:03:16 2019 -0500

    LP1805856: Open new windows for record operations
    
    This branch changes the call from $window.location.open
    to match other others ($window.open). Testing the 2 z39.50
    changes worked as expected!
    
    Signed-off-by: Jason Boyer <jboyer at library.in.gov>
    Signed-off-by: Galen Charlton <gmc at equinoxinitiative.org>

diff --git a/Open-ILS/web/js/ui/default/staff/cat/bucket/record/app.js b/Open-ILS/web/js/ui/default/staff/cat/bucket/record/app.js
index 59a2fac..aebfb25 100644
--- a/Open-ILS/web/js/ui/default/staff/cat/bucket/record/app.js
+++ b/Open-ILS/web/js/ui/default/staff/cat/bucket/record/app.js
@@ -699,7 +699,7 @@ function($scope,  $q , $routeParams,  bucketSvc,  egCore,  $window,
                     args.lead_id,
                     args.records.map(function(val) { return val.id; })
                 ).then(function() {
-                    $window.location.open(egCore.env.basePath + 'cat/catalog/record/' + args.lead_id);
+                    $window.open(egCore.env.basePath + 'cat/catalog/record/' + args.lead_id);
                 });
             });
         });

commit ad10ddb1e690af8ae3a3049748972bb9873f7c50
Author: Jane Sandberg <sandbej at linnbenton.edu>
Date:   Thu Dec 6 16:42:49 2018 -0800

    LP1805856: Open records in new tabs
    
    Catalogers have given the feedback that it's very helpful to have
    certain records open in a new tab after they perform certain tasks.
    
    This commit opens the relevant records in a new tab in the following
    circumstances:
    1) Cataloging > Z39.50 > Import > Go to record (previously opened in the
    existing tab)
    2) Cataloging > Z39.50 > Overlay > Overlay (previously did not open the
    overlaid record at all)
    3) Cataloging > Record Buckets > Merge (previously opened the lead
    record in the existing tab)
    
    Signed-off-by: Jane Sandberg <sandbej at linnbenton.edu>
    Signed-off-by: Jason Boyer <JBoyer at library.in.gov>
    Signed-off-by: Galen Charlton <gmc at equinoxinitiative.org>

diff --git a/Open-ILS/web/js/ui/default/staff/cat/bucket/record/app.js b/Open-ILS/web/js/ui/default/staff/cat/bucket/record/app.js
index 4637f00..59a2fac 100644
--- a/Open-ILS/web/js/ui/default/staff/cat/bucket/record/app.js
+++ b/Open-ILS/web/js/ui/default/staff/cat/bucket/record/app.js
@@ -699,8 +699,7 @@ function($scope,  $q , $routeParams,  bucketSvc,  egCore,  $window,
                     args.lead_id,
                     args.records.map(function(val) { return val.id; })
                 ).then(function() {
-                    $window.location.href =
-                        egCore.env.basePath + 'cat/catalog/record/' + args.lead_id;
+                    $window.location.open(egCore.env.basePath + 'cat/catalog/record/' + args.lead_id);
                 });
             });
         });
diff --git a/Open-ILS/web/js/ui/default/staff/cat/z3950/app.js b/Open-ILS/web/js/ui/default/staff/cat/z3950/app.js
index 2e67eea..b524797 100644
--- a/Open-ILS/web/js/ui/default/staff/cat/z3950/app.js
+++ b/Open-ILS/web/js/ui/default/staff/cat/z3950/app.js
@@ -251,9 +251,7 @@ function($scope , $q , $location , $timeout , $window,  egCore , egGridDataProvi
                         egCore.strings.GO_TO_RECORD,
                         egCore.strings.GO_BACK
                     ).result.then(function() {
-                        // NOTE: $location.path('/cat/catalog/record/' + result.id()) did not work
-                        // for some reason
-                        $window.location.href = egCore.env.basePath + 'cat/catalog/record/' + result.id();
+                        $window.open(egCore.env.basePath + 'cat/catalog/record/' + result.id());
                     });
                 }
             }
@@ -452,6 +450,7 @@ function($scope , $q , $location , $timeout , $window,  egCore , egGridDataProvi
                     $scope.local_overlay_target = 0;
                     egCore.hatch.removeLocalItem('eg.cat.marked_overlay_record');
                     console.debug('overlay complete, target removed');
+                    $window.open(egCore.env.basePath + 'cat/catalog/record/' + overlay_target);
                 }
             );            
         });

-----------------------------------------------------------------------

Summary of changes:
 .../js/ui/default/staff/cat/bucket/record/app.js   |    3 +--
 Open-ILS/web/js/ui/default/staff/cat/z3950/app.js  |    5 ++---
 2 files changed, 3 insertions(+), 5 deletions(-)


hooks/post-receive
-- 
Evergreen ILS