[open-ils-commits] [GIT] Evergreen ILS branch rel_3_2 updated. c17db014849d3950a32b8dc54528409754ab2043

[Evergreen Git]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Evergreen ILS".

The branch, rel_3_2 has been updated
       via  c17db014849d3950a32b8dc54528409754ab2043 (commit)
      from  8200320cf263ff38bef7207fd056cfc7d7e219ad (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit c17db014849d3950a32b8dc54528409754ab2043
Author: Galen Charlton <gmc at equinoxinitiative.org>
Date:   Fri May 24 11:06:04 2019 -0400

    LP#1830394: remove console noise from the holdings editor
    
    This patch removes browser console noise that occurs (among other
    places) when moving a working item to the completed list in
    the holdings editor
    
    TypeError: "$scope.working.MultiMap[keys[i]] is undefined"
        hasMulti https://evergreen.example.org/js/ui/default/staff/cat/volcopy/app.js:1203
        ...
    
    To test
    -------
    [1] Open the holdings editor to add or edit an item, then open the
        browser debug console.
    [2] Make a change and move the item from working to complete. Note
        that the error message above shows up repeated in the
        console log.
    [3] Apply the patch and repeat steps 1 and 2. This time, the errors
        should not appear.
    
    Signed-off-by: Galen Charlton <gmc at equinoxinitiative.org>
    Signed-off-by: Kyle Huckins <khuckins at catalyte.io>
    Signed-off-by: Bill Erickson <berickxx at gmail.com>

diff --git a/Open-ILS/web/js/ui/default/staff/cat/volcopy/app.js b/Open-ILS/web/js/ui/default/staff/cat/volcopy/app.js
index 272416cea9..2634843f26 100644
--- a/Open-ILS/web/js/ui/default/staff/cat/volcopy/app.js
+++ b/Open-ILS/web/js/ui/default/staff/cat/volcopy/app.js
@@ -1404,10 +1404,11 @@ function($scope , $q , $window , $routeParams , $location , $timeout , egCore ,
 
         $scope.clearWorking = function () {
             angular.forEach($scope.working, function (v,k,o) {
+                if (k != 'MultiMap') $scope.working.MultiMap[k] = [];
                 if (!angular.isObject(v)) {
                     if (typeof v != 'undefined')
                         $scope.working[k] = undefined;
-                } else if (k != 'circ_lib') {
+                } else if (k != 'circ_lib' && k != 'MultiMap') {
                     angular.forEach(v, function (sv,sk) {
                         if (typeof v != 'undefined')
                             $scope.working[k][sk] = undefined;
@@ -2553,11 +2554,12 @@ function($scope , $q , $window , $routeParams , $location , $timeout , egCore ,
 
                 $scope.clearWorking = function () {
                     angular.forEach($scope.working, function (v,k,o) {
+                        if (k != 'MultiMap') $scope.working.MultiMap[k] = [];
                         $scope.working.MultiMap[k] = [];
                         if (!angular.isObject(v)) {
                             if (typeof v != 'undefined')
                                 $scope.working[k] = undefined;
-                        } else if (k != 'circ_lib') {
+                        } else if (k != 'circ_lib' && k != 'MultiMap') {
                             angular.forEach(v, function (sv,sk) {
                                 $scope.working[k][sk] = undefined;
                             });

-----------------------------------------------------------------------

Summary of changes:
 Open-ILS/web/js/ui/default/staff/cat/volcopy/app.js | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)


hooks/post-receive
-- 
Evergreen ILS