[open-ils-commits] [GIT] Evergreen ILS branch rel_3_3 updated. d4515549db91101d1b5638f6f1153bd6a8cf0e72

Evergreen Git git at git.evergreen-ils.org
Tue Jul 30 10:31:52 EDT 2019


This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Evergreen ILS".

The branch, rel_3_3 has been updated
       via  d4515549db91101d1b5638f6f1153bd6a8cf0e72 (commit)
       via  0e6d2234e93d4dc97c005d6238ba39116ea56f89 (commit)
      from  f62cea11ae59de16f9142754199b0ac0c0df2738 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit d4515549db91101d1b5638f6f1153bd6a8cf0e72
Author: Galen Charlton <gmc at equinoxinitiative.org>
Date:   Fri May 24 14:04:33 2019 -0400

    LP#1796903: (follow-up) disabled the calendar button when the text input is disabled
    
    Disabling the calendar button when the datepicker is disabled allows
    ChromeVox (at least) to skip past a button that cannot be invoked
    until (like is possible in the checkout page) the picker is enabled.
    
    Signed-off-by: Galen Charlton <gmc at equinoxinitiative.org>
    Signed-off-by: Jane Sandberg <sandbej at linnbenton.edu>
    Signed-off-by: Galen Charlton <gmc at equinoxinitiative.org>

diff --git a/Open-ILS/src/templates/staff/share/t_datetime.tt2 b/Open-ILS/src/templates/staff/share/t_datetime.tt2
index dbeb7193b5..9d83d30d7c 100644
--- a/Open-ILS/src/templates/staff/share/t_datetime.tt2
+++ b/Open-ILS/src/templates/staff/share/t_datetime.tt2
@@ -18,7 +18,7 @@
         close-text="{{closeText}}"/>
       <span class="input-group-btn">
         <button type="button" class="btn btn-default"
-          ng-click="datePickerIsOpen=!datePickerIsOpen"
+          ng-click="datePickerIsOpen=!datePickerIsOpen" ng-disabled="ngDisabled"
           aria-label="Select a date" aria-pressed="{{datePickerIsOpen || false}}">
           <span class="glyphicon glyphicon-calendar" title="Select a date"></span>
         </button>

commit 0e6d2234e93d4dc97c005d6238ba39116ea56f89
Author: Jane Sandberg <sandbej at linnbenton.edu>
Date:   Tue Oct 9 07:37:56 2018 -0700

    LP1796903: Make date picker calendar button more accessible
    
    To test:
    
    1) After applying this commit, navigate to a place in the Web client
    that includes a date picker (such as the checkin screen).
    2) Hover over the calendar button with your mouse and confirm that a
    tooltip appears.
    3) Verify that the button element has an aria-label attribute.
    4) Verify that the button element has an aria-pressed attribute that
    is false when the date picker is closed; true when it is open.
    5) Use a screen reader (like NVDA or ChromeVox).  Verify that when you
    tab over to the date picker, the user is informed of the aria-label
    and aria-pressed values
    
    Signed-off-by: Jane Sandberg <sandbej at linnbenton.edu>
    Signed-off-by: Galen Charlton <gmc at equinoxinitiative.org>

diff --git a/Open-ILS/src/templates/staff/share/t_datetime.tt2 b/Open-ILS/src/templates/staff/share/t_datetime.tt2
index 1f505db319..dbeb7193b5 100644
--- a/Open-ILS/src/templates/staff/share/t_datetime.tt2
+++ b/Open-ILS/src/templates/staff/share/t_datetime.tt2
@@ -18,8 +18,9 @@
         close-text="{{closeText}}"/>
       <span class="input-group-btn">
         <button type="button" class="btn btn-default"
-          ng-click="datePickerIsOpen=!datePickerIsOpen">
-          <i class="glyphicon glyphicon-calendar"></i>
+          ng-click="datePickerIsOpen=!datePickerIsOpen"
+          aria-label="Select a date" aria-pressed="{{datePickerIsOpen || false}}">
+          <span class="glyphicon glyphicon-calendar" title="Select a date"></span>
         </button>
       </span>
     </div>

-----------------------------------------------------------------------

Summary of changes:
 Open-ILS/src/templates/staff/share/t_datetime.tt2 | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)


hooks/post-receive
-- 
Evergreen ILS


More information about the open-ils-commits mailing list