[open-ils-commits] [GIT] Evergreen ILS branch rel_3_3 updated. a49095883458ced07c2ec4b56559f8648490303b

[Evergreen Git]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Evergreen ILS".

The branch, rel_3_3 has been updated
       via  a49095883458ced07c2ec4b56559f8648490303b (commit)
      from  c3d7726e56bf9de793e123056be61659a74e289f (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit a49095883458ced07c2ec4b56559f8648490303b
Author: Garry Collum <gcollum at gmail.com>
Date:   Fri May 18 19:57:42 2018 -0400

    LP1766982 - CSV downloads contain the string 'null' for null values.
    
    Adds a check for null and undefined in the getItemTextContent function
    in grid.js which is called by both the code to download grid data as
    CSV and for printing grids.
    
    To test
    1. Place holds on a couple of titles, one of which has no author. In the
       test data TCN 226, The Crow, has no author data.
    2. Pull up the Holds Pull List.
    3. Download Full CSV - to download the CSV file and view it in a
       spreadsheet or text editor looking specifically at the Author column.
    4. Print Full Grid - to view the data in a printout, since this function
       also affects printing.
    5. Go back to the Holds Pull List and click on one of the barcodes under
       the Current Copy column.
    6. Click on the List View.
    7. Download Full CSV - open the resulting file to inspect the
       Alert Message data.
    8. Apply patch and repeat steps 2-7.
    
    Signed-off-by: gcollum <gcollum at gmail.com>
    Signed-off-by: Josh Stompro <stompro at stompro.org>
    Signed-off-by: Galen Charlton <gmc at equinoxinitiative.org>

diff --git a/Open-ILS/web/js/ui/default/staff/services/grid.js b/Open-ILS/web/js/ui/default/staff/services/grid.js
index 5c9d5f0fdf..732ec59bfe 100644
--- a/Open-ILS/web/js/ui/default/staff/services/grid.js
+++ b/Open-ILS/web/js/ui/default/staff/services/grid.js
@@ -1121,6 +1121,7 @@ angular.module('egGridMod',
                     }
                 } else {
                     val = grid.dataProvider.itemFieldValue(item, col);
+                    if (val === null || val === undefined || val === '') return '';
                     val = $filter('egGridValueFilter')(val, col, item);
                 }
                 return val;

-----------------------------------------------------------------------

Summary of changes:
 Open-ILS/web/js/ui/default/staff/services/grid.js | 1 +
 1 file changed, 1 insertion(+)


hooks/post-receive
-- 
Evergreen ILS