[open-ils-commits] [GIT] Evergreen ILS branch rel_3_3 updated. ce1132b18492d2c0615f667c23134daede7d92ce

[Evergreen Git]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Evergreen ILS".

The branch, rel_3_3 has been updated
       via  ce1132b18492d2c0615f667c23134daede7d92ce (commit)
      from  a49095883458ced07c2ec4b56559f8648490303b (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit ce1132b18492d2c0615f667c23134daede7d92ce
Author: Bill Erickson <berickxx at gmail.com>
Date:   Wed Jul 3 11:05:47 2019 -0400

    LP1834969 Indicate failures in Angular login
    
    Display a Login Failed message in the Angular staff login form when a
    login attempt fails.
    
    Signed-off-by: Bill Erickson <berickxx at gmail.com>
    Signed-off-by: Galen Charlton <gmc at equinoxinitiative.org>

diff --git a/Open-ILS/src/eg2/src/app/staff/login.component.html b/Open-ILS/src/eg2/src/app/staff/login.component.html
index ba474f809f..60bc630757 100644
--- a/Open-ILS/src/eg2/src/app/staff/login.component.html
+++ b/Open-ILS/src/eg2/src/app/staff/login.component.html
@@ -48,9 +48,12 @@
         </div>
 
         <div class="row">
-          <div class="col-lg-8 offset-lg-4 pl-0">
+          <div class="col-lg-2 offset-lg-4 pl-0">
             <button type="submit" class="btn btn-outline-dark" i18n>Sign in</button>
           </div>
+          <div class="col-lg-4" *ngIf="loginFailed">
+            <div class="badge badge-warning p-2" i18n>Login Failed</div>
+          </div>
         </div>
       </form>
     </fieldset>
diff --git a/Open-ILS/src/eg2/src/app/staff/login.component.ts b/Open-ILS/src/eg2/src/app/staff/login.component.ts
index 2c1ac2a26e..de889f9fb2 100644
--- a/Open-ILS/src/eg2/src/app/staff/login.component.ts
+++ b/Open-ILS/src/eg2/src/app/staff/login.component.ts
@@ -11,6 +11,7 @@ import {StoreService} from '@eg/core/store.service';
 export class StaffLoginComponent implements OnInit {
 
     workstations: any[];
+    loginFailed: boolean;
 
     args = {
       username : '',
@@ -65,6 +66,7 @@ export class StaffLoginComponent implements OnInit {
 
         const workstation: string = this.args.workstation;
 
+        this.loginFailed = false;
         this.auth.login(this.args).then(
             ok => {
                 this.auth.redirectUrl = null;
@@ -86,7 +88,7 @@ export class StaffLoginComponent implements OnInit {
                 }
             },
             notOk => {
-                // indicate failure in the UI.
+                this.loginFailed = true;
             }
         );
     }

-----------------------------------------------------------------------

Summary of changes:
 Open-ILS/src/eg2/src/app/staff/login.component.html | 5 ++++-
 Open-ILS/src/eg2/src/app/staff/login.component.ts   | 4 +++-
 2 files changed, 7 insertions(+), 2 deletions(-)


hooks/post-receive
-- 
Evergreen ILS