[open-ils-commits] [GIT] Evergreen ILS branch rel_3_1 updated. cf5c12e442e043cc2d25c8d6345917e00e348e91

[Evergreen Git]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Evergreen ILS".

The branch, rel_3_1 has been updated
       via  cf5c12e442e043cc2d25c8d6345917e00e348e91 (commit)
      from  aa8449b24641ebb2c065e2bbe74d2396157e2c85 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit cf5c12e442e043cc2d25c8d6345917e00e348e91
Author: Galen Charlton <gmc at equinoxinitiative.org>
Date:   Fri Apr 19 16:29:21 2019 -0400

    LP#1812900: fix retention of saved defaults in holdings editor
    
    Because the $watch on the statistical category default OU filter
    in the holdings editor can fire before the form is fully initialized,
    saved defaults (i.e., the cat.copy.defaults workstation setting)
    could get overwritten with the hard-coded default value for that, er,
    set of defaults.
    
    This patch ensures that that $watch saves the defaults only when the
    value of the default stat cat OU filter has changed.
    
    To test
    -------
    [1] Use the holdings editor on an item. Change to the defaults
        tab and check or uncheck checkboxes such as "Use checkdigit"
        and "Print Item Labels on Save and Exit"
    [2] Refresh the page or open the holdings editor on a different item.
        Note that the settings from step #1 are not retained.
    [3] Apply the patch.
    [4] Repeat steps #1 and #2. This time, the settings should be retained.
    [5] Set the Default Filter Library in the same tab and refresh. Verify
        that the OU you chose is retained.
    
    Signed-off-by: Galen Charlton <gmc at equinoxinitiative.org>
    Signed-off-by: Remington Steed <rjs7 at calvin.edu>
    Signed-off-by: John Amundson <jsamundson at cwmars.org>
    Signed-off-by: Janet Schrader <jschrader at cwmars.org>
    Signed-off-by: Jason Stephenson <jason at sigio.com>

diff --git a/Open-ILS/web/js/ui/default/staff/cat/volcopy/app.js b/Open-ILS/web/js/ui/default/staff/cat/volcopy/app.js
index 625065553e..2bf10843a8 100644
--- a/Open-ILS/web/js/ui/default/staff/cat/volcopy/app.js
+++ b/Open-ILS/web/js/ui/default/staff/cat/volcopy/app.js
@@ -1090,8 +1090,9 @@ function($scope , $q , $window , $routeParams , $location , $timeout , egCore ,
         });
     }
 
-    $scope.$watch('defaults.statcat_filter', function() {
-        $scope.saveDefaults();
+    $scope.$watch('defaults.statcat_filter', function(n,o) {
+        if (n && n != o)
+            $scope.saveDefaults();
     });
     $scope.$watch('defaults.auto_gen_barcode', function (n,o) {
         itemSvc.auto_gen_barcode = n

-----------------------------------------------------------------------

Summary of changes:
 Open-ILS/web/js/ui/default/staff/cat/volcopy/app.js | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)


hooks/post-receive
-- 
Evergreen ILS