[open-ils-commits] [GIT] Evergreen ILS branch master updated. 1522d95ec18dec4fb562df8b29c2437a8faac5a0

[Evergreen Git]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Evergreen ILS".

The branch, master has been updated
       via  1522d95ec18dec4fb562df8b29c2437a8faac5a0 (commit)
      from  c09ef9a36cabb111b052ca57ad5a92aca91bafc0 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 1522d95ec18dec4fb562df8b29c2437a8faac5a0
Author: Bill Erickson <berickxx at gmail.com>
Date:   Wed Mar 27 12:43:32 2019 -0400

    Coerce numbers for bib IDs in Angular staff catalog
    
    Under some circumstances, the search results screen in the new
    experimental Angular staff catalog did not display any results (though
    it did show the pager, facets, etc.).
    
    This was traced back to the results array attempting to be populated
    with ID values of '-1' instead of the real IDs.  Coercing the incoming
    IDs to numbers appears to resolve the issue.
    
    Signed-off-by: Bill Erickson <berickxx at gmail.com>
    Signed-off-by: Dan Wells <dbw2 at calvin.edu>

diff --git a/Open-ILS/src/eg2/src/app/share/catalog/bib-record.service.ts b/Open-ILS/src/eg2/src/app/share/catalog/bib-record.service.ts
index d536c8beb5..b2058e7aed 100644
--- a/Open-ILS/src/eg2/src/app/share/catalog/bib-record.service.ts
+++ b/Open-ILS/src/eg2/src/app/share/catalog/bib-record.service.ts
@@ -33,7 +33,7 @@ export class BibRecordSummary {
     net: NetService;
 
     constructor(record: IdlObject, orgId: number, orgDepth: number) {
-        this.id = record.id();
+        this.id = Number(record.id());
         this.record = record;
         this.orgId = orgId;
         this.orgDepth = orgDepth;
@@ -221,7 +221,7 @@ export class BibRecordService {
         // Reconsider this approach (see also note above about API).
         this.getBibSummary(metabib.master_record(), orgId, orgDepth)
         .subscribe(summary => {
-            summary.metabibId = metabib.id();
+            summary.metabibId = Number(metabib.id());
             summary.metabibRecords =
                 metabib.source_maps().map(m => Number(m.source()));
 
diff --git a/Open-ILS/src/eg2/src/app/share/catalog/search-context.ts b/Open-ILS/src/eg2/src/app/share/catalog/search-context.ts
index 7e5f8109e6..f18a8cde2d 100644
--- a/Open-ILS/src/eg2/src/app/share/catalog/search-context.ts
+++ b/Open-ILS/src/eg2/src/app/share/catalog/search-context.ts
@@ -276,7 +276,7 @@ export class CatalogSearchContext {
     }
 
     addResultId(id: number, resultIdx: number ): void {
-        this.resultIds[resultIdx + this.pager.offset] = id;
+        this.resultIds[resultIdx + this.pager.offset] = Number(id);
     }
 
     // Return the record at the requested index.

-----------------------------------------------------------------------

Summary of changes:
 Open-ILS/src/eg2/src/app/share/catalog/bib-record.service.ts | 4 ++--
 Open-ILS/src/eg2/src/app/share/catalog/search-context.ts     | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)


hooks/post-receive
-- 
Evergreen ILS