[open-ils-commits] [GIT] Evergreen ILS branch rel_3_3 updated. 7f917178539842e51f71ba2bfd29403fbf78a32a

[Evergreen Git]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Evergreen ILS".

The branch, rel_3_3 has been updated
       via  7f917178539842e51f71ba2bfd29403fbf78a32a (commit)
       via  530010e20377caa9b82c37dc8f465896d07342f2 (commit)
      from  0ed480929c4f5c8ff11c4757d59eb69c3ebdcdd8 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 7f917178539842e51f71ba2bfd29403fbf78a32a
Author: Jason Stephenson <jason at sigio.com>
Date:   Tue Dec 18 09:26:11 2018 -0500

    Lp 1752968: Select content when focusing on the barcode field.
    
    To reproduce the reported behavior:
    
     1. Find a title in the staff client catalog.
     2. Click on Add Holdings.
     3. See that the Barcode field does not have cursor focus.
     4. Repeat step 1.
     5. Click on edit next to one of the barcoded items in the list of
        holdings.
     6. Click Show Holdings Details and see that the Barcode field does
         not have focus and the content is not selected.
    
    To test this branch:
    
     1. Find a title in the staff client catalog.
     2. Click on Add Holdings.
     3. See that the Barcode field has cursor focus, i.e. the cursor is in
        the field and blinking.
     4. Repeat step 1.
     5. Click on edit next to one of the barcoded items in the list of
        holdings.
     6. Click Show Holdings Details and see that the Barcode field has
         cursor focus and the content is selected/highlighted.
    
    Signed-off-by: Jason Stephenson <jason at sigio.com>
    Signed-off-by: Janet Schrader <jschrader at cwmars.org>

diff --git a/Open-ILS/web/js/ui/default/staff/cat/volcopy/app.js b/Open-ILS/web/js/ui/default/staff/cat/volcopy/app.js
index 8eda695b3b..507c4cbb10 100644
--- a/Open-ILS/web/js/ui/default/staff/cat/volcopy/app.js
+++ b/Open-ILS/web/js/ui/default/staff/cat/volcopy/app.js
@@ -489,7 +489,7 @@ function(egCore , $q) {
                     '<input id="{{callNumber.id()}}_{{copy.id()}}"'+
                     ' eg-enter="nextBarcode(copy.id())" class="form-control"'+
                     ' type="text" ng-model="barcode" ng-change="updateBarcode()"'+
-                    ' autofocus/>'+
+                    ' ng-focus="selectOnFocus($event)" autofocus/>'+
                     '<div class="label label-danger" ng-if="duplicate_barcode">{{duplicate_barcode_string}}</div>'+
                     '<div class="label label-danger" ng-if="empty_barcode">{{empty_barcode_string}}</div>'+
                 '</div>'+
@@ -509,6 +509,11 @@ function(egCore , $q) {
 
                 if (!$scope.copy.barcode()) $scope.copy.empty_barcode = true;
 
+                $scope.selectOnFocus = function($event) {
+                    if (!$scope.copy.empty_barcode)
+                        $event.target.select();
+                }
+
                 $scope.nextBarcode = function (i) {
                     $scope.focusNext(i, $scope.barcode);
                 }

commit 530010e20377caa9b82c37dc8f465896d07342f2
Author: Jason Stephenson <jason at sigio.com>
Date:   Mon Dec 17 11:08:47 2018 -0500

    Lp 1752968: Focus Barcode Field in Volumes/Copy Editor
    
    Always focus the barcode field when adding or editing volumes or
    copies.
    
    Signed-off-by: Jason Stephenson <jason at sigio.com>
    Signed-off-by: Janet Schrader <jschrader at cwmars.org>

diff --git a/Open-ILS/web/js/ui/default/staff/cat/volcopy/app.js b/Open-ILS/web/js/ui/default/staff/cat/volcopy/app.js
index 76e637a163..8eda695b3b 100644
--- a/Open-ILS/web/js/ui/default/staff/cat/volcopy/app.js
+++ b/Open-ILS/web/js/ui/default/staff/cat/volcopy/app.js
@@ -488,7 +488,8 @@ function(egCore , $q) {
                 '<div class="col-xs-5" ng-class="{'+"'has-error'"+':barcode_has_error}">'+
                     '<input id="{{callNumber.id()}}_{{copy.id()}}"'+
                     ' eg-enter="nextBarcode(copy.id())" class="form-control"'+
-                    ' type="text" ng-model="barcode" ng-change="updateBarcode()"/>'+
+                    ' type="text" ng-model="barcode" ng-change="updateBarcode()"'+
+                    ' autofocus/>'+
                     '<div class="label label-danger" ng-if="duplicate_barcode">{{duplicate_barcode_string}}</div>'+
                     '<div class="label label-danger" ng-if="empty_barcode">{{empty_barcode_string}}</div>'+
                 '</div>'+

-----------------------------------------------------------------------

Summary of changes:
 Open-ILS/web/js/ui/default/staff/cat/volcopy/app.js | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)


hooks/post-receive
-- 
Evergreen ILS