[open-ils-commits] [GIT] Evergreen ILS branch rel_3_1 updated. 63a41ffce4d92023b9607964ba1c9268ffcec894

[Evergreen Git]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Evergreen ILS".

The branch, rel_3_1 has been updated
       via  63a41ffce4d92023b9607964ba1c9268ffcec894 (commit)
      from  a072c700e72815373c6f11b14c170532c83f5f35 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 63a41ffce4d92023b9607964ba1c9268ffcec894
Author: Jeff Godin <jgodin at tadl.org>
Date:   Tue Oct 2 08:32:54 2018 -0400

    LP#1796942 Treat VISA SIP payments as credit card
    
    Treat sip_payment_type 01 (VISA) as a credit_card_payment.
    
    Previously, we only handled payment type 02 (credit card) and 01
    fell through to be treated as a cash_payment.
    
    Signed-off-by: Jeff Godin <jgodin at tadl.org>
    Signed-off-by: Galen Charlton <gmc at equinoxinitiative.org>
    Signed-off-by: Bill Erickson <berickxx at gmail.com>

diff --git a/Open-ILS/src/perlmods/lib/OpenILS/SIP/Transaction/FeePayment.pm b/Open-ILS/src/perlmods/lib/OpenILS/SIP/Transaction/FeePayment.pm
index b9c0654553..df424dda3f 100644
--- a/Open-ILS/src/perlmods/lib/OpenILS/SIP/Transaction/FeePayment.pm
+++ b/Open-ILS/src/perlmods/lib/OpenILS/SIP/Transaction/FeePayment.pm
@@ -189,7 +189,8 @@ sub do_fee_payment {
 sub pay_bills {
     my ($self, $paymentref) = @_;
     my $user = $self->patron->{user};
-    if ($self->sip_payment_type eq '02') {
+    if ($self->sip_payment_type eq '02' || $self->sip_payment_type eq '01') {
+        # '01' is "VISA"
         # '02' is "credit card"
         my $transaction_id = $self->transaction_id ? $self->transaction_id : 'Not provided by SIP client';
         return $U->simplereq('open-ils.circ', 'open-ils.circ.money.payment', $self->{authtoken},

-----------------------------------------------------------------------

Summary of changes:
 Open-ILS/src/perlmods/lib/OpenILS/SIP/Transaction/FeePayment.pm | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)


hooks/post-receive
-- 
Evergreen ILS