[open-ils-commits] [GIT] Evergreen ILS branch rel_3_1 updated. 46111cc283637939e5f1f2bcbceaa94eaddbddb4

[Evergreen Git]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Evergreen ILS".

The branch, rel_3_1 has been updated
       via  46111cc283637939e5f1f2bcbceaa94eaddbddb4 (commit)
      from  4f01a25a2018d04e1108a061afd4878b4396cb07 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 46111cc283637939e5f1f2bcbceaa94eaddbddb4
Author: Dan Pearl <dpearl at cwmars.org>
Date:   Tue Apr 10 14:45:47 2018 -0400

    LP1760893 Add Holdings Part dropdown should list items in order
    
    Without a defined sort, the Part dropdown when editing a holding simply
    displays in database order.  Let's be more deterministic about it.
    
    In this case, while slightly surprising, consensus opinion was that
    reverse order on label_sortkey provides the best overall usability.
    This is obviously true on records with many parts, but can help in all
    cases.
    
    Signed-off-by: Dan Pearl <dpearl at cwmars.org>
    Signed-off-by: Dan Wells <dbw2 at calvin.edu>

diff --git a/Open-ILS/web/js/ui/default/staff/cat/volcopy/app.js b/Open-ILS/web/js/ui/default/staff/cat/volcopy/app.js
index b43c66f079..625065553e 100644
--- a/Open-ILS/web/js/ui/default/staff/cat/volcopy/app.js
+++ b/Open-ILS/web/js/ui/default/staff/cat/volcopy/app.js
@@ -272,7 +272,8 @@ function(egCore , $q) {
 
         return egCore.pcrud.search('bmp',
             {record : rec, deleted : 'f'},
-            null, {atomic : true}
+            {order_by: {bmp : 'label_sortkey DESC'}},
+            {atomic : true}
         ).then(function(list) {
             service.bmp_parts[rec] = list;
             return list;

-----------------------------------------------------------------------

Summary of changes:
 Open-ILS/web/js/ui/default/staff/cat/volcopy/app.js | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)


hooks/post-receive
-- 
Evergreen ILS