[open-ils-commits] [GIT] Evergreen ILS branch rel_3_4 updated. 633e987bf2d733af5e2cbc3b2f0f1906e18754a4
Evergreen Git
git at git.evergreen-ils.org
Fri Nov 1 15:40:41 EDT 2019
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Evergreen ILS".
The branch, rel_3_4 has been updated
via 633e987bf2d733af5e2cbc3b2f0f1906e18754a4 (commit)
via 1678790a4965c7ee756b620ff5b4c262cbfa1831 (commit)
via 1c251ecdd5b1a4fce5a506c4d33b5921e3e59a4e (commit)
from fee6598129436b834ddf893f6d83bc7dcf2c768e (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit 633e987bf2d733af5e2cbc3b2f0f1906e18754a4
Author: Kyle Huckins <khuckins at catalyte.io>
Date: Fri Jul 5 14:36:05 2019 +0000
lp1437103 Allow Receipts to Print when Suppressing Popups
- Move suppress_popup check further along and allow transit receipts
to properly print when popups suppressed.
Signed-off-by: Kyle Huckins <khuckins at catalyte.io>
Changes to be committed:
modified: Open-ILS/web/js/ui/default/staff/circ/services/circ.js
Signed-off-by: Bill Erickson <berickxx at gmail.com>
diff --git a/Open-ILS/web/js/ui/default/staff/circ/services/circ.js b/Open-ILS/web/js/ui/default/staff/circ/services/circ.js
index 502b96aa40..4a3ce9c54f 100644
--- a/Open-ILS/web/js/ui/default/staff/circ/services/circ.js
+++ b/Open-ILS/web/js/ui/default/staff/circ/services/circ.js
@@ -1779,7 +1779,6 @@ function($uibModal , $q , egCore , egAlertDialog , egConfirmDialog, egAddCopyAl
}
service.route_dialog = function(tmpl, evt, params, options) {
- if (options.suppress_popups) return;
if (angular.isArray(evt)) evt = evt[0];
return service.collect_route_data(tmpl, evt, params, options)
@@ -1846,7 +1845,7 @@ function($uibModal , $q , egCore , egAlertDialog , egConfirmDialog, egAddCopyAl
// when auto-print is on, skip the dialog and go straight
// to printing.
- if (options.auto_print_holds_transits)
+ if (options.auto_print_holds_transits || options.suppress_popups)
return print_transit(template);
return $uibModal.open({
commit 1678790a4965c7ee756b620ff5b4c262cbfa1831
Author: Kyle Huckins <khuckins at catalyte.io>
Date: Wed Jun 26 15:36:09 2019 +0000
lp1437103 Suppress Popups on Patron Items Out Checkin
- Make Patron Items Out UI respect Suppress Popups setting.
Signed-off-by: Kyle Huckins <khuckins at catalyte.io>
Changes to be committed:
modified: Open-ILS/web/js/ui/default/staff/circ/patron/items_out.js
Signed-off-by: Bill Erickson <berickxx at gmail.com>
diff --git a/Open-ILS/web/js/ui/default/staff/circ/patron/items_out.js b/Open-ILS/web/js/ui/default/staff/circ/patron/items_out.js
index 327eeb5fe6..96cc65cd6b 100644
--- a/Open-ILS/web/js/ui/default/staff/circ/patron/items_out.js
+++ b/Open-ILS/web/js/ui/default/staff/circ/patron/items_out.js
@@ -30,6 +30,12 @@ function($scope , $q , $routeParams , $timeout , egCore , egUser , patronSvc ,
// list of alt circs (lost, etc.) and/or check-in with fines circs
$scope.alt_list = [];
+
+ egCore.org.settings([
+ 'ui.circ.suppress_checkin_popups' // add other settings as needed
+ ]).then(function(set) {
+ $scope.suppress_popups = set['ui.circ.suppress_checkin_popups'];
+ });
// these are fetched during startup (i.e. .configure())
// By default, show lost/lo/cr items in the alt list
@@ -511,26 +517,31 @@ function($scope , $q , $routeParams , $timeout , egCore , egUser , patronSvc ,
if (!items.length) return;
var copies = items.map(function(circ) { return circ.target_copy() });
var barcodes = copies.map(function(copy) { return copy.barcode() });
-
- return egConfirmDialog.open(
- egCore.strings.CHECK_IN_CONFIRM, barcodes.join(' '), {
-
- }).result.then(function() {
- var copy;
- function do_one() {
- if (copy = copies.pop()) {
- // Checkin expects a barcode, but will pass other
- // parameters too. Passing the copy ID allows
- // for the checkin of deleted copies on the server.
- egCirc.checkin(
- {copy_barcode: copy.barcode(), copy_id: copy.id()})
- .finally(do_one);
- } else {
- reset_page();
- }
+
+ var copy;
+ function do_one() {
+ if (copy = copies.pop()) {
+ // Checkin expects a barcode, but will pass other
+ // parameters too. Passing the copy ID allows
+ // for the checkin of deleted copies on the server.
+ egCirc.checkin(
+ {copy_barcode: copy.barcode(), copy_id: copy.id()},
+ {suppress_popups: $scope.suppress_popups})
+ .finally(do_one);
+ } else {
+ reset_page();
}
- do_one(); // kick it off
- });
+ }
+ if ($scope.suppress_popups) {
+ do_one();
+ } else {
+ return egConfirmDialog.open(
+ egCore.strings.CHECK_IN_CONFIRM, barcodes.join(' '), {
+
+ }).result.then(function() {
+ do_one(); // kick it off
+ });
+ }
}
$scope.add_billing = function(items) {
commit 1c251ecdd5b1a4fce5a506c4d33b5921e3e59a4e
Author: Kyle Huckins <khuckins at catalyte.io>
Date: Tue Jun 25 16:47:04 2019 +0000
lp1437103 - Suppress Popups based on OU Setting
- Allow OU setting to suppress checkin popups to properly take effect.
Signed-off-by: Kyle Huckins <khuckins at catalyte.io>
Changes to be committed:
modified: Open-ILS/web/js/ui/default/staff/circ/services/circ.js
Signed-off-by: Bill Erickson <berickxx at gmail.com>
diff --git a/Open-ILS/web/js/ui/default/staff/circ/services/circ.js b/Open-ILS/web/js/ui/default/staff/circ/services/circ.js
index 8c104ccd13..502b96aa40 100644
--- a/Open-ILS/web/js/ui/default/staff/circ/services/circ.js
+++ b/Open-ILS/web/js/ui/default/staff/circ/services/circ.js
@@ -459,7 +459,7 @@ function($uibModal , $q , egCore , egAlertDialog , egConfirmDialog, egAddCopyAl
}
- if (options.suppress_checkin_popups
+ if (options.suppress_popups
&& evt.filter(function(e){return service.checkin_suppress_overrides.indexOf(e.textcode) == -1;}).length == 0) {
// Events are suppressed. Re-run the checkin w/ override.
options.override = true;
@@ -1606,7 +1606,7 @@ function($uibModal , $q , egCore , egAlertDialog , egConfirmDialog, egAddCopyAl
var copy = evt && evt.payload ? evt.payload.copy : null;
- if (copy && !options.suppress_checkin_popups
+ if (copy && !options.suppress_popups
&& copy.location().checkin_alert() == 't') {
return egAlertDialog.open(
@@ -1685,7 +1685,7 @@ function($uibModal , $q , egCore , egAlertDialog , egConfirmDialog, egAddCopyAl
case 11: /* CATALOGING */
egCore.audio.play('info.checkin.cataloging');
evt[0].route_to = egCore.strings.ROUTE_TO_CATALOGING;
- if (options.no_precat_alert)
+ if (options.no_precat_alert || options.suppress_popups)
return $q.when(final_resp);
return egAlertDialog.open(
egCore.strings.PRECAT_CHECKIN_MSG, params)
@@ -1712,6 +1712,7 @@ function($uibModal , $q , egCore , egAlertDialog , egConfirmDialog, egAddCopyAl
case 'ASSET_COPY_NOT_FOUND':
egCore.audio.play('error.checkin.not_found');
+ if (options.suppress_popups) return $q.when(final_resp);
return egAlertDialog.open(
egCore.strings.UNCAT_ALERT_DIALOG, params)
.result.then(function() {return final_resp});
@@ -1719,7 +1720,7 @@ function($uibModal , $q , egCore , egAlertDialog , egConfirmDialog, egAddCopyAl
case 'ITEM_NOT_CATALOGED':
egCore.audio.play('error.checkin.not_cataloged');
evt[0].route_to = egCore.strings.ROUTE_TO_CATALOGING;
- if (options.no_precat_alert)
+ if (options.no_precat_alert || options.suppress_popups)
return $q.when(final_resp);
return egAlertDialog.open(
egCore.strings.PRECAT_CHECKIN_MSG, params)
@@ -1778,6 +1779,7 @@ function($uibModal , $q , egCore , egAlertDialog , egConfirmDialog, egAddCopyAl
}
service.route_dialog = function(tmpl, evt, params, options) {
+ if (options.suppress_popups) return;
if (angular.isArray(evt)) evt = evt[0];
return service.collect_route_data(tmpl, evt, params, options)
-----------------------------------------------------------------------
Summary of changes:
.../js/ui/default/staff/circ/patron/items_out.js | 49 +++++++++++++---------
.../web/js/ui/default/staff/circ/services/circ.js | 11 ++---
2 files changed, 36 insertions(+), 24 deletions(-)
hooks/post-receive
--
Evergreen ILS
More information about the open-ils-commits
mailing list