[open-ils-commits] [GIT] Evergreen ILS branch rel_3_4 updated. 2969e2f41c72c2369ae70cb7092fcac5188e968a

Evergreen Git git at git.evergreen-ils.org
Wed Nov 6 12:11:21 EST 2019


This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Evergreen ILS".

The branch, rel_3_4 has been updated
       via  2969e2f41c72c2369ae70cb7092fcac5188e968a (commit)
      from  633e987bf2d733af5e2cbc3b2f0f1906e18754a4 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 2969e2f41c72c2369ae70cb7092fcac5188e968a
Author: Galen Charlton <gmc at equinoxinitiative.org>
Date:   Wed Nov 6 11:35:58 2019 -0500

    LP#1851524: fix adding a bucket when saving a new carousel
    
    This patch fixes a regression where saving a new carousel
    would not result in its bucket being created due to the
    post-save callback never getting invoked.
    
    This patch does not fix any carousels that do not have
    buckets due to this bug. Because such carousels will
    not function anyway, they should be deleted and
    recreated by the local admin.
    
    To test
    -------
    [1] Create a new carousel in local adminstration. Open it
        in the edit modal again and note that no record bucket
        is linked to it.
    [2] Apply the patch and repeat step 1. This time, the
        bucket should be created.
    
    Signed-off-by: Galen Charlton <gmc at equinoxinitiative.org>
    
    Signed-off-by: Chris Sharp <csharp at georgialibraries.org>

diff --git a/Open-ILS/src/eg2/src/app/staff/admin/local/admin-carousel.component.html b/Open-ILS/src/eg2/src/app/staff/admin/local/admin-carousel.component.html
index 6c3e7834d1..64714af755 100644
--- a/Open-ILS/src/eg2/src/app/staff/admin/local/admin-carousel.component.html
+++ b/Open-ILS/src/eg2/src/app/staff/admin/local/admin-carousel.component.html
@@ -90,7 +90,7 @@
 <eg-fm-record-editor #editDialog idlClass="{{idlClass}}" 
     [preloadLinkedValues]="true" readonlyFields="last_refresh_time"
     hiddenFieldsList="creator,editor,create_time,edit_time"
-    [preSave]="mungeCarousel" (onSave$)="postSave($event)"
+    [preSave]="mungeCarousel" (recordSaved)="postSave($event)"
     readonlyFields="last_refresh_time"
     [fieldOptions]="{bucket:{customTemplate:{template:bucketTemplate}},copy_location_filter:{customTemplate:{template:locationTemplate}},owning_lib_filter:{customTemplate:{template:orgTemplate}}}"
 ></eg-fm-record-editor>

-----------------------------------------------------------------------

Summary of changes:
 .../src/eg2/src/app/staff/admin/local/admin-carousel.component.html     | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)


hooks/post-receive
-- 
Evergreen ILS


More information about the open-ils-commits mailing list