[open-ils-commits] [GIT] Evergreen ILS branch rel_3_4 updated. dd30484a566a9acf71688db39726e7aba8920501

[Evergreen Git]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Evergreen ILS".

The branch, rel_3_4 has been updated
       via  dd30484a566a9acf71688db39726e7aba8920501 (commit)
      from  ed38b3f393060f32687fee9185ffece0f7011766 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit dd30484a566a9acf71688db39726e7aba8920501
Author: Dan Wells <dbw2 at calvin.edu>
Date:   Tue Oct 22 10:55:41 2019 -0400

    LP#1846038 Remove extra grid refresh from configuration load
    
    Bug LP#1790169 added the ability to save sorting configuration, but it
    also added an additional grid refresh to the configuration load.  This
    breaks grid loading.
    
    The expected flow is for is to first load any existing configuration,
    then do the first collect() for the grid.  This refresh() call adds
    potentially a second collect() which may run earlier than it should,
    and overall does not seem necessary.
    
    To test:
    
    (Make sure you are testing on current master or rel_3_3/3_4, or you
    will (like me) hit related bugs which have been fixed.  Also, some
    grids (especially circ) do not honor sort for other reasons, so avoid
    those for now.)
    
    1) Find a grid which has a typical get() process.  Suggestion would be
    a basic auto grid, such as full bill details,
    https://localhost/eg/staff/circ/patron/11/bill/43/details .
    2) Set a sort value you can see, then *save* the configuration.
    3) Before the patch, billing details grid doesn't load.  After patch,
    grid loads and still honors the defined sort.
    
    Signed-off-by: Dan Wells <dbw2 at calvin.edu>
    Signed-off-by: Remington Steed <rjs7 at calvin.edu>
    Signed-off-by: Mike Rylander <mrylander at gmail.com>

diff --git a/Open-ILS/web/js/ui/default/staff/services/grid.js b/Open-ILS/web/js/ui/default/staff/services/grid.js
index 1d5df7dea3..6224cb97c8 100644
--- a/Open-ILS/web/js/ui/default/staff/services/grid.js
+++ b/Open-ILS/web/js/ui/default/staff/services/grid.js
@@ -256,7 +256,6 @@ angular.module('egGridMod',
                     // link columns to scope after loadConfig(), since it
                     // replaces the columns array.
                     $scope.columns = grid.columnsProvider.columns;
-                    grid.dataProvider.refresh();
                 });
 
                 // NOTE: grid.collect() is first called from link(), not here.

-----------------------------------------------------------------------

Summary of changes:
 Open-ILS/web/js/ui/default/staff/services/grid.js | 1 -
 1 file changed, 1 deletion(-)


hooks/post-receive
-- 
Evergreen ILS