[open-ils-commits] [GIT] Evergreen ILS branch master updated. 63f7c2448017a2c50ba95ed25bc0e5c89671d060

[Evergreen Git]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Evergreen ILS".

The branch, master has been updated
       via  63f7c2448017a2c50ba95ed25bc0e5c89671d060 (commit)
      from  500a2a84e06bd62639a87994c6a190c315e5cfb4 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 63f7c2448017a2c50ba95ed25bc0e5c89671d060
Author: Bill Erickson <berickxx at gmail.com>
Date:   Tue Oct 22 13:52:56 2019 -0400

    LP1830973 Angular 8 org family test spec repair
    
    The test runner does not like that the test expectations are wrapped in
    the fixture.whenStable promise.  It reports an error, since no
    expectations occur in line with the test:
    
    ERROR: 'Spec 'Component: OrgFamilySelect allows user to turn off
    includeDescendants checkbox' has no expectations.'
    
    As the whenStable checks do not appear to be necessary, simply removing
    them resolves the issue and allows the tests to succeed.
    
    Signed-off-by: Bill Erickson <berickxx at gmail.com>
    Signed-off-by: Jason Etheridge <jason at EquinoxInitiative.org>

diff --git a/Open-ILS/src/eg2/src/app/share/org-family-select/org-family-select.component.spec.ts b/Open-ILS/src/eg2/src/app/share/org-family-select/org-family-select.component.spec.ts
index f93b386216..f389e7ad5e 100644
--- a/Open-ILS/src/eg2/src/app/share/org-family-select/org-family-select.component.spec.ts
+++ b/Open-ILS/src/eg2/src/app/share/org-family-select/org-family-select.component.spec.ts
@@ -64,51 +64,39 @@ describe('Component: OrgFamilySelect', () => {
 
 
     it('provides includeAncestors checkbox by default', () => {
-        fixture.whenStable().then(() => {
-            includeAncestors = fixture.debugElement.query(By.css('#family-test-include-ancestors'));
-            expect(includeAncestors.nativeElement).toBeTruthy();
-        });
+        includeAncestors = fixture.debugElement.query(By.css('#family-test-include-ancestors'));
+        expect(includeAncestors.nativeElement).toBeTruthy();
     });
 
     it('provides includeDescendants checkbox by default', () => {
-        fixture.whenStable().then(() => {
-            includeDescendants = fixture.debugElement.query(By.css('#family-test-include-descendants'));
-            expect(includeDescendants.nativeElement).toBeTruthy();
-        });
+        includeDescendants = fixture.debugElement.query(By.css('#family-test-include-descendants'));
+        expect(includeDescendants.nativeElement).toBeTruthy();
     });
 
     it('allows user to turn off includeAncestors checkbox', () => {
-        fixture.whenStable().then(() => {
-            component.hideAncestorSelector = true;
-            fixture.detectChanges();
-            includeAncestors = fixture.debugElement.query(By.css('#family-test-include-ancestors'));
-            expect(includeAncestors).toBeNull();
-        });
+        component.hideAncestorSelector = true;
+        fixture.detectChanges();
+        includeAncestors = fixture.debugElement.query(By.css('#family-test-include-ancestors'));
+        expect(includeAncestors).toBeNull();
     });
 
     it('allows user to turn off includeDescendants checkbox', () => {
-        fixture.whenStable().then(() => {
-            component.hideDescendantSelector = true;
-            fixture.detectChanges();
-            includeDescendants = fixture.debugElement.query(By.css('#family-test-include-descendants'));
-            expect(includeDescendants).toBeNull();
-        });
+        component.hideDescendantSelector = true;
+        fixture.detectChanges();
+        includeDescendants = fixture.debugElement.query(By.css('#family-test-include-descendants'));
+        expect(includeDescendants).toBeNull();
     });
 
     it('disables includeAncestors checkbox when root OU is chosen', () => {
-        fixture.whenStable().then(() => {
-            fixture.detectChanges();
-            includeAncestors = fixture.debugElement.query(By.css('#family-test-include-ancestors'));
-            expect(includeAncestors.nativeElement.disabled).toBe(true);
-        });
+        fixture.detectChanges();
+        includeAncestors = fixture.debugElement.query(By.css('#family-test-include-ancestors'));
+        expect(includeAncestors.nativeElement.disabled).toBe(true);
     });
 
     it('disables includeAncestors checkbox when OU has no children', () => {
-        fixture.whenStable().then(() => {
-            fixture.detectChanges();
-            includeDescendants = fixture.debugElement.query(By.css('#family-test-include-descendants'));
-            expect(includeDescendants.nativeElement.disabled).toBe(true);
-        });
+        fixture.detectChanges();
+        includeDescendants = fixture.debugElement.query(By.css('#family-test-include-descendants'));
+        expect(includeDescendants.nativeElement.disabled).toBe(true);
     });
 
 });

-----------------------------------------------------------------------

Summary of changes:
 .../org-family-select.component.spec.ts            | 48 ++++++++--------------
 1 file changed, 18 insertions(+), 30 deletions(-)


hooks/post-receive
-- 
Evergreen ILS