[open-ils-commits] [GIT] Evergreen ILS branch rel_3_4 updated. ed731e27367a9ee70458219f127e0d0b5a454f07

[Evergreen Git]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Evergreen ILS".

The branch, rel_3_4 has been updated
       via  ed731e27367a9ee70458219f127e0d0b5a454f07 (commit)
      from  57c24c346f1e36767b76a8291c73b8098c8b644f (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit ed731e27367a9ee70458219f127e0d0b5a454f07
Author: Terran McCanna <tmccanna at georgialibraries.org>
Date:   Mon Oct 21 17:18:44 2019 -0400

    LP#1839361 Login page tile is confusing to screen readers
    
    Prior to this change, the login page, the splash page, and the
    about page in the staff client all used 'Home' as the page title,
    which caused accessibility problems. This change gives each
    its own title.
    
    Signed-off-by: Terran McCanna <tmccanna at georgialibraries.org>
    Signed-off-by: Lynn Floyd <lfloyd1 at library.in.gov>
    Signed-off-by: Chris Sharp <csharp at georgialibraries.org>

diff --git a/Open-ILS/src/templates/staff/index.tt2 b/Open-ILS/src/templates/staff/index.tt2
index 803774f31d..100d9d1dc5 100644
--- a/Open-ILS/src/templates/staff/index.tt2
+++ b/Open-ILS/src/templates/staff/index.tt2
@@ -1,12 +1,18 @@
 [%
   WRAPPER "staff/base.tt2";
-  ctx.page_title = l("Home"); 
   ctx.page_app = "egHome";
 %]
 
 [% BLOCK APP_JS %]
 <!-- splash / login page app -->
 <script src="[% ctx.media_prefix %]/js/ui/default/staff/app.js"></script>
+<script>
+angular.module('egCoreMod').run(['egStrings', function(s) {
+  s.PAGE_TITLE_SPLASH = "[% l('Home') %]";
+  s.PAGE_TITLE_LOGIN = "[% l('Staff Login') %]";
+  s.PAGE_TITLE_ABOUT = "[% l('About') %]";
+}])
+</script>
 [% END %]
 
 <div ng-view></div> 
diff --git a/Open-ILS/web/js/ui/default/staff/app.js b/Open-ILS/web/js/ui/default/staff/app.js
index e38b76f92d..672104676a 100644
--- a/Open-ILS/web/js/ui/default/staff/app.js
+++ b/Open-ILS/web/js/ui/default/staff/app.js
@@ -56,7 +56,10 @@ function($routeProvider , $locationProvider) {
         $scope.focusMe = true;
         $scope.args = {};
         $scope.workstations = [];
-
+		
+		egCore.strings.setPageTitle(
+            egCore.strings['PAGE_TITLE_LOGIN']);
+			
         // if the user is already logged in, jump to splash page
         if (egCore.auth.user()) $location.path('/');
 
@@ -150,9 +153,13 @@ function($routeProvider , $locationProvider) {
 /**
  * Splash page dynamic content.
  */
-.controller('SplashCtrl', ['$scope', '$window', function($scope, $window) {
-    console.log('SplashCtrl');
+.controller('SplashCtrl', ['$scope', '$window','egCore', 
+    function($scope, $window,egCore) {
+		
     $scope.focus_search = true;
+	
+	egCore.strings.setPageTitle(
+        egCore.strings['PAGE_TITLE_SPLASH']);
 
     $scope.catalog_search = function($event) {
         $scope.focus_search = true;
@@ -179,5 +186,8 @@ function($routeProvider , $locationProvider) {
         }
     );
 
+	egCore.strings.setPageTitle(
+        egCore.strings['PAGE_TITLE_ABOUT']);
+
 }])
 

-----------------------------------------------------------------------

Summary of changes:
 Open-ILS/src/templates/staff/index.tt2  |  8 +++++++-
 Open-ILS/web/js/ui/default/staff/app.js | 16 +++++++++++++---
 2 files changed, 20 insertions(+), 4 deletions(-)


hooks/post-receive
-- 
Evergreen ILS