[open-ils-commits] [GIT] Evergreen ILS branch rel_3_4 updated. 813a8e7a1cad47e4ba62844d3daf6209e4716920

[Evergreen Git]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Evergreen ILS".

The branch, rel_3_4 has been updated
       via  813a8e7a1cad47e4ba62844d3daf6209e4716920 (commit)
      from  024c879e25cc990ab5faf01606e1e85f2dce2825 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 813a8e7a1cad47e4ba62844d3daf6209e4716920
Author: Galen Charlton <gmc at equinoxinitiative.org>
Date:   Thu Feb 13 16:49:46 2020 -0500

    LP#1863386: link ADMIN_CAROUSEL permission to appropriate OU context
    
    This patch restricts prcrud retrieval and modification of templates
    to users who have ADMIN_CAROUSEL in the relevant carousel owner OU
    rather than requiring global_required.
    
    To test
    -------
    [1] Apply the patch.
    [2] Ensure that a user with ADMIN_CAROUSEL privileges at a depth
        lower than "Consortium" can only view and edit carousel
        definitions at OUs applicable to their working libraries.
    
    Signed-off-by: Galen Charlton <gmc at equinoxinitiative.org>
    Signed-off-by: Mike Rylander <mrylander at gmail.com>
    Signed-off-by: Jennifer Weston <jennifer.weston at equinoxinitiative.org>

diff --git a/Open-ILS/examples/fm_IDL.xml b/Open-ILS/examples/fm_IDL.xml
index 75b52a7597..70d4a14979 100644
--- a/Open-ILS/examples/fm_IDL.xml
+++ b/Open-ILS/examples/fm_IDL.xml
@@ -13019,10 +13019,10 @@ SELECT  usr,
 		</links>
 		<permacrud xmlns="http://open-ils.org/spec/opensrf/IDL/permacrud/v1">
 			<actions>
-				<create permission="ADMIN_CAROUSEL" global_required="true"/>
-				<retrieve/>
-				<update permission="ADMIN_CAROUSEL" global_required="true"/>
-				<delete permission="ADMIN_CAROUSEL" global_required="true"/>
+				<create permission="ADMIN_CAROUSEL" context_field="owner"/>
+				<retrieve permission="ADMIN_CAROUSEL" context_field="owner"/>
+				<update permission="ADMIN_CAROUSEL" context_field="owner"/>
+				<delete permission="ADMIN_CAROUSEL" context_field="owner"/>
 			</actions>
 		</permacrud>
 	</class>
@@ -13045,10 +13045,18 @@ SELECT  usr,
 		</links>
 		<permacrud xmlns="http://open-ils.org/spec/opensrf/IDL/permacrud/v1">
 			<actions>
-				<create permission="ADMIN_CAROUSEL" global_required="true"/>
-				<retrieve/>
-				<update permission="ADMIN_CAROUSEL" global_required="true"/>
-				<delete permission="ADMIN_CAROUSEL" global_required="true"/>
+				<create permission="ADMIN_CAROUSEL">
+				    <context link="carousel" field="owner" />
+				</create>
+				<retrieve permission="ADMIN_CAROUSEL">
+				    <context link="carousel" field="owner" />
+				</retrieve>
+				<update permission="ADMIN_CAROUSEL">
+				    <context link="carousel" field="owner" />
+				</update>
+				<delete permission="ADMIN_CAROUSEL">
+				    <context link="carousel" field="owner" />
+				</delete>
 			</actions>
 		</permacrud>
 	</class>

-----------------------------------------------------------------------

Summary of changes:
 Open-ILS/examples/fm_IDL.xml | 24 ++++++++++++++++--------
 1 file changed, 16 insertions(+), 8 deletions(-)


hooks/post-receive
-- 
Evergreen ILS