[open-ils-commits] [GIT] Evergreen ILS branch master updated. 978bd61d500c41995128ef0284ec630dcc6cd376

[Evergreen Git]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Evergreen ILS".

The branch, master has been updated
       via  978bd61d500c41995128ef0284ec630dcc6cd376 (commit)
      from  593901297aee361be563d524a15a431035e1adfd (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 978bd61d500c41995128ef0284ec630dcc6cd376
Author: Mike Rylander <mrylander at gmail.com>
Date:   Thu Dec 5 15:12:57 2019 -0500

    LP#1855329: Hold shelf query speed problem
    
    In bug 1827250 I suggested Jason Stephenson look at an alternate SQL
    formulation to solve the original problem. He did, and deemed it faster,
    so went with that. Unfortunately, on PG 9.6, we're seeing some data sets
    that decide on a /very/ poor plan for the wide-hold query with the
    solution as implemented, but the original suggestion from Jason works
    fine.
    
    In the face of evidence controverting my thought that giving PG more
    options for planning is better in this case, this commit moves to his
    original query change.
    
    Signed-off-by: Mike Rylander <mrylander at gmail.com>
    Signed-off-by: Jason Stephenson <jason at sigio.com>
    Signed-off-by: Galen Charlton <gmc at equinoxinitiative.org>

diff --git a/Open-ILS/src/perlmods/lib/OpenILS/Application/Storage/Publisher/action.pm b/Open-ILS/src/perlmods/lib/OpenILS/Application/Storage/Publisher/action.pm
index 213ed59e5a..2a5c87e9b4 100644
--- a/Open-ILS/src/perlmods/lib/OpenILS/Application/Storage/Publisher/action.pm
+++ b/Open-ILS/src/perlmods/lib/OpenILS/Application/Storage/Publisher/action.pm
@@ -2146,7 +2146,8 @@ sub wide_hold_data {
                 SELECT  id
                   FROM  action.hold_request recheck
                   WHERE recheck.current_copy = cp.id
-                  ORDER BY capture_time DESC NULLS LAST
+                        AND recheck.capture_time IS NOT NULL
+                  ORDER BY capture_time DESC
                   LIMIT 1
             )))
         SQL

-----------------------------------------------------------------------

Summary of changes:
 .../src/perlmods/lib/OpenILS/Application/Storage/Publisher/action.pm   | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)


hooks/post-receive
-- 
Evergreen ILS