[open-ils-commits] [GIT] Evergreen ILS branch rel_3_4 updated. ed894762a29d90ddb0eb5faff2166668355cd9fd

Evergreen Git git at git.evergreen-ils.org
Tue Jul 28 09:53:51 EDT 2020


This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Evergreen ILS".

The branch, rel_3_4 has been updated
       via  ed894762a29d90ddb0eb5faff2166668355cd9fd (commit)
      from  8ed4dce43fadcfe0dbbb38f8a34c3259101fb82c (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit ed894762a29d90ddb0eb5faff2166668355cd9fd
Author: Bill Erickson <berickxx at gmail.com>
Date:   Mon Jun 8 16:03:14 2020 -0400

    LP1882591 Empty combobox avoids default selection
    
    When clearing a combobox value, no combobox options are displayed in the
    dropdown.  This allows users to clear the value then tab out of the box
    without the typeahead magic forcing selection of the first entry.
    
    The full list can still be displayed by clicking on the combobox.
    
    Signed-off-by: Bill Erickson <berickxx at gmail.com>
    Signed-off-by: Galen Charlton <gmc at equinoxinitiative.org>

diff --git a/Open-ILS/src/eg2/src/app/share/combobox/combobox.component.ts b/Open-ILS/src/eg2/src/app/share/combobox/combobox.component.ts
index a7a6c3bf72..d4d7961ccf 100644
--- a/Open-ILS/src/eg2/src/app/share/combobox/combobox.component.ts
+++ b/Open-ILS/src/eg2/src/app/share/combobox/combobox.component.ts
@@ -371,12 +371,13 @@ export class ComboboxComponent implements ControlValueAccessor, OnInit {
             mergeMap(term => this.addAsyncEntries(term)),
             map((term: string) => {
 
-                if (term === '' || term === '_CLICK_') {
-                    if (!this.asyncDataSource) {
-                        // In sync mode, a post-focus empty search or
-                        // click event displays the whole list.
-                        return this.entrylist;
-                    }
+                // Display no values when the input is empty and no
+                // click action occurred.
+                if (term === '') { return []; }
+
+                // In sync-data mode, a click displays the full list.
+                if (term === '_CLICK_' && !this.asyncDataSource) {
+                    return this.entrylist;
                 }
 
                 // Filter entrylist whose labels substring-match the

-----------------------------------------------------------------------

Summary of changes:
 .../src/eg2/src/app/share/combobox/combobox.component.ts    | 13 +++++++------
 1 file changed, 7 insertions(+), 6 deletions(-)


hooks/post-receive
-- 
Evergreen ILS


More information about the open-ils-commits mailing list