[open-ils-commits] [GIT] Evergreen ILS branch rel_3_4 updated. 70856ddb9fcccc997677eb64890ca2e8713f4fe5

[Evergreen Git]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Evergreen ILS".

The branch, rel_3_4 has been updated
       via  70856ddb9fcccc997677eb64890ca2e8713f4fe5 (commit)
      from  99ebe4e7df8fce5fccaf3707bb489ce5fb1b4a69 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 70856ddb9fcccc997677eb64890ca2e8713f4fe5
Author: Jeff Davis <jdavis at sitka.bclibraries.ca>
Date:   Tue Oct 8 16:00:12 2019 -0700

    LP#1847343: fix Exclude Electronic Resources checkbox when locale picker is enabled
    
    Signed-off-by: Jeff Davis <jdavis at sitka.bclibraries.ca>
    Signed-off-by: Jane Sandberg <sandbej at linnbenton.edu>
    Signed-off-by: Galen Charlton <gmc at equinoxinitiative.org>

diff --git a/Open-ILS/web/js/ui/default/opac/simple.js b/Open-ILS/web/js/ui/default/opac/simple.js
index c1138147bc..816304b732 100644
--- a/Open-ILS/web/js/ui/default/opac/simple.js
+++ b/Open-ILS/web/js/ui/default/opac/simple.js
@@ -108,11 +108,9 @@ function exclude_onchange(checkbox) {
         var reg = /-search_format\(electronic\)/g;
         search_box.value = search_box.value.replace(reg, "");
         // Remove from the search form itself
-        var search_format_inputs = document.getElementsByName("fi:-search_format");
+        var search_format_inputs = document.querySelectorAll('input[type="hidden"][name="fi:-search_format"][value="electronic"]');
         for (var j = 0; j < search_format_inputs.length; j++) {
-            if (search_format_inputs[j].value == 'electronic') {
-                search_format_inputs[j].parentNode.removeChild(search_format_inputs[j]);
-            }
+            search_format_inputs[j].parentNode.removeChild(search_format_inputs[j]);
         }
 
     }

-----------------------------------------------------------------------

Summary of changes:
 Open-ILS/web/js/ui/default/opac/simple.js | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)


hooks/post-receive
-- 
Evergreen ILS