[open-ils-commits] [GIT] Evergreen ILS branch rel_3_3 updated. 646472d0fa9fbdc27f18a23656f7a635085e700a

[Evergreen Git]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Evergreen ILS".

The branch, rel_3_3 has been updated
       via  646472d0fa9fbdc27f18a23656f7a635085e700a (commit)
      from  d3fae9b54bfd6cc0c24a8e9b54fba21e03eb98e9 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 646472d0fa9fbdc27f18a23656f7a635085e700a
Author: Jason Stephenson <jason at sigio.com>
Date:   Thu Mar 26 10:47:46 2020 -0400

    LP1813088: Coerce Values to String in egGridValueFilter
    
    Coerce values to string in the switch for Boolean columns in the main
    egGridValueFilter function.  This came about after an IRC conversation
    with Mike Rylander who suggested this as a possible fix.  It should
    when field values are strings, integers, or Booleans.
    
    Signed-off-by: Jason Stephenson <jason at sigio.com>
    Signed-off-by: Chris Sharp <csharp at georgialibraries.org>

diff --git a/Open-ILS/web/js/ui/default/staff/services/grid.js b/Open-ILS/web/js/ui/default/staff/services/grid.js
index 83a1ebb727..ce84caa657 100644
--- a/Open-ILS/web/js/ui/default/staff/services/grid.js
+++ b/Open-ILS/web/js/ui/default/staff/services/grid.js
@@ -2337,15 +2337,14 @@ angular.module('egGridMod',
     var GVF = function(value, column, item) {
         switch(column.datatype) {
             case 'bool':
-                switch(value) {
-                    // Browser will translate true/false for us
+                switch(''+value) {
                     case 't' : 
                     case '1' :  // legacy
-                    case true:
+                    case 'true':
                         return egStrings.YES;
                     case 'f' : 
                     case '0' :  // legacy
-                    case false:
+                    case 'false':
                         return egStrings.NO;
                     // value may be null,  '', etc.
                     default : return '';

-----------------------------------------------------------------------

Summary of changes:
 Open-ILS/web/js/ui/default/staff/services/grid.js | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)


hooks/post-receive
-- 
Evergreen ILS