[open-ils-commits] [GIT] Evergreen ILS branch master updated. be3abe46b045a0edaea95dfc755d0df028c57ab1

[Evergreen Git]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Evergreen ILS".

The branch, master has been updated
       via  be3abe46b045a0edaea95dfc755d0df028c57ab1 (commit)
      from  4d864ff2126f3dfc02551cd274817bb891a5e18d (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit be3abe46b045a0edaea95dfc755d0df028c57ab1
Author: Jason Stephenson <jason at sigio.com>
Date:   Thu Mar 26 10:47:46 2020 -0400

    LP1813088: Coerce Values to String in egGridValueFilter
    
    Coerce values to string in the switch for Boolean columns in the main
    egGridValueFilter function.  This came about after an IRC conversation
    with Mike Rylander who suggested this as a possible fix.  It should
    when field values are strings, integers, or Booleans.
    
    Signed-off-by: Jason Stephenson <jason at sigio.com>
    Signed-off-by: Chris Sharp <csharp at georgialibraries.org>

diff --git a/Open-ILS/web/js/ui/default/staff/services/grid.js b/Open-ILS/web/js/ui/default/staff/services/grid.js
index 83a1ebb727..ce84caa657 100644
--- a/Open-ILS/web/js/ui/default/staff/services/grid.js
+++ b/Open-ILS/web/js/ui/default/staff/services/grid.js
@@ -2337,15 +2337,14 @@ angular.module('egGridMod',
     var GVF = function(value, column, item) {
         switch(column.datatype) {
             case 'bool':
-                switch(value) {
-                    // Browser will translate true/false for us
+                switch(''+value) {
                     case 't' : 
                     case '1' :  // legacy
-                    case true:
+                    case 'true':
                         return egStrings.YES;
                     case 'f' : 
                     case '0' :  // legacy
-                    case false:
+                    case 'false':
                         return egStrings.NO;
                     // value may be null,  '', etc.
                     default : return '';

-----------------------------------------------------------------------

Summary of changes:
 Open-ILS/web/js/ui/default/staff/services/grid.js | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)


hooks/post-receive
-- 
Evergreen ILS