[open-ils-commits] [GIT] Evergreen ILS branch master updated. 69f9ec751b8c613d1acfecf1fb8e7d7eb6a1607f

[Evergreen Git]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Evergreen ILS".

The branch, master has been updated
       via  69f9ec751b8c613d1acfecf1fb8e7d7eb6a1607f (commit)
      from  e0d7705b9b8cb79fb58e451b0dca19393371a5de (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 69f9ec751b8c613d1acfecf1fb8e7d7eb6a1607f
Author: Jeff Davis <jdavis at sitka.bclibraries.ca>
Date:   Tue Apr 28 13:52:52 2020 -0700

    LP#1865533: save changes on Edit Hold in My Account
    
    When editing a hold in the OPAC, changes are not saved if the SMS field
    is blank.  The sms_notify value is being passed as an empty string, and
    this non-null value violates the "sms_check" constraint on
    action.hold_request.  Replacing the empty string with undef allows the
    hold update to succeed.
    
    Signed-off-by: Jeff Davis <jdavis at sitka.bclibraries.ca>
    Signed-off-by: Terran McCanna <tmccanna at georgialibraries.org>
    Signed-off-by: Chris Sharp <csharp at georgialibraries.org>

diff --git a/Open-ILS/src/perlmods/lib/OpenILS/WWW/EGCatLoader/Account.pm b/Open-ILS/src/perlmods/lib/OpenILS/WWW/EGCatLoader/Account.pm
index e246bd591c..6579300132 100644
--- a/Open-ILS/src/perlmods/lib/OpenILS/WWW/EGCatLoader/Account.pm
+++ b/Open-ILS/src/perlmods/lib/OpenILS/WWW/EGCatLoader/Account.pm
@@ -1224,7 +1224,7 @@ sub handle_hold_update {
             $val->{"pickup_lib"} = $self->cgi->param("pickup_lib");
             $val->{"email_notify"} = $self->cgi->param("email_notify") ? 1 : 0;
             $val->{"phone_notify"} = $self->cgi->param("phone_notify");
-            $val->{"sms_notify"} = $self->cgi->param("sms_notify");
+            $val->{"sms_notify"} = ( $self->cgi->param("sms_notify") eq '' ) ? undef : $self->cgi->param("sms_notify");
             $val->{"sms_carrier"} = int($self->cgi->param("sms_carrier")) if $val->{"sms_notify"};
 
             for my $field (qw/expire_time thaw_date/) {

-----------------------------------------------------------------------

Summary of changes:
 Open-ILS/src/perlmods/lib/OpenILS/WWW/EGCatLoader/Account.pm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)


hooks/post-receive
-- 
Evergreen ILS