<div dir="ltr">Jane, <div><br></div><div>Is there an equivalent <!-- eslint-disable --> for templates?</div><div><br></div><div>-b</div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Fri, May 10, 2024 at 12:24 PM Stephanie Leary via Evergreen-dev <<a href="mailto:evergreen-dev@list.evergreen-ils.org">evergreen-dev@list.evergreen-ils.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div class="gmail_default" style="font-size:small">
+1 to pausing for now. It is possible to lint a single directory at a
time, so we should be
able to isolate various projects and tackle them individually later. We
know the issues came in on April 26, so that tells us where to start. </div><div><br></div><div><div style="font-size:small" class="gmail_default">Jane, my only objection to
/* eslint-disable */ is that there are just so many files in Acq and Reports that it would be tedious to edit each one.<br></div><br></div><br>Stephanie Leary<div><div dir="ltr" class="gmail_signature"><div dir="ltr">Front End Developer<br>Equinox Open Library Initiative<br>stephanie.leary@equinoxOLI.org<br><a href="https://www.equinoxOLI.org" target="_blank">https://www.equinoxOLI.org</a><br>phone: 877-OPEN-ILS (673-6457)</div></div></div><br></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Fri, May 10, 2024 at 11:17 AM Jane Sandberg via Evergreen-dev <<a href="mailto:evergreen-dev@list.evergreen-ils.org" target="_blank">evergreen-dev@list.evergreen-ils.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="auto"><div>My preference would be to put an /* eslint-disable */ at the top of the relevant files, instead. It keeps the linter green, and is a clue to future readers of the code "look out, there may be some unusual stuff in here, lint-wise"</div><div dir="auto"><br></div><div dir="auto">I worry that if we get used to the linter failing, we will stop paying attention to it.</div><div dir="auto"><br></div><div dir="auto">My $0.02, with appreciation to the release team.<br><br><div class="gmail_quote" dir="auto"><div dir="ltr" class="gmail_attr">On Fri, May 10, 2024, 8:57 AM Mike Rylander via Evergreen-dev <<a href="mailto:evergreen-dev@list.evergreen-ils.org" target="_blank">evergreen-dev@list.evergreen-ils.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="auto"><div>+1 from me, for sure.</div><div><br></div><div>Regards,<br><br>Mike Rylander<br><br>-- Sent from my phone, please pardon my thumbs.<br> | Research and Development Manager<br> | Equinox Open Library Initiative<br> | phone: 1-877-OPEN-ILS (673-6457)<br> | email: miker@EquinoxInitiative.org<br> | web: <a href="http://EquinoxInitiative.org" rel="noreferrer" target="_blank">http://EquinoxInitiative.org</a></div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Fri, May 10, 2024, 11:49 AM Bill Erickson via Evergreen-dev <<a href="mailto:evergreen-dev@list.evergreen-ils.org" rel="noreferrer" target="_blank">evergreen-dev@list.evergreen-ils.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr">Hi All,<br><div><br></div><div>We're bumping against a lot of Angular lint errors on pending feature branches as a result of relatively recent linting rules, some of which will require significant refactoring to resolve. </div><div><br></div><div>Note that 'ng lint --fix' helps, but it only fixes certain classes of errors, mostly cosmetic.</div><div><br></div><div>These feature branches have been tested in the wild and are generally ready to go. Efforts have been made to resolve the lint issues, but some fixes, like batch changing "==" to "===" can cause problems, since the original code was not created and tested with those assumptions in place. Other more complicated issues could take days or longer to fix and re-test.</div><div><br></div><div>I propose we relax our requirement that merged code be fully cleared of lint errors at merge time until we get through this phase of feature merging.</div><div><br></div><div>Thoughts?</div><div><br></div><div>Thanks,</div><div><br></div><div>-b</div><div><br></div><div><br></div><div> </div></div>
_______________________________________________<br>
Evergreen-dev mailing list<br>
<a href="mailto:Evergreen-dev@list.evergreen-ils.org" rel="noreferrer noreferrer" target="_blank">Evergreen-dev@list.evergreen-ils.org</a><br>
<a href="http://list.evergreen-ils.org/cgi-bin/mailman/listinfo/evergreen-dev" rel="noreferrer noreferrer noreferrer" target="_blank">http://list.evergreen-ils.org/cgi-bin/mailman/listinfo/evergreen-dev</a><br>
</blockquote></div>
_______________________________________________<br>
Evergreen-dev mailing list<br>
<a href="mailto:Evergreen-dev@list.evergreen-ils.org" rel="noreferrer" target="_blank">Evergreen-dev@list.evergreen-ils.org</a><br>
<a href="http://list.evergreen-ils.org/cgi-bin/mailman/listinfo/evergreen-dev" rel="noreferrer noreferrer" target="_blank">http://list.evergreen-ils.org/cgi-bin/mailman/listinfo/evergreen-dev</a><br>
</blockquote></div></div></div>
_______________________________________________<br>
Evergreen-dev mailing list<br>
<a href="mailto:Evergreen-dev@list.evergreen-ils.org" target="_blank">Evergreen-dev@list.evergreen-ils.org</a><br>
<a href="http://list.evergreen-ils.org/cgi-bin/mailman/listinfo/evergreen-dev" rel="noreferrer" target="_blank">http://list.evergreen-ils.org/cgi-bin/mailman/listinfo/evergreen-dev</a><br>
</blockquote></div>
_______________________________________________<br>
Evergreen-dev mailing list<br>
<a href="mailto:Evergreen-dev@list.evergreen-ils.org" target="_blank">Evergreen-dev@list.evergreen-ils.org</a><br>
<a href="http://list.evergreen-ils.org/cgi-bin/mailman/listinfo/evergreen-dev" rel="noreferrer" target="_blank">http://list.evergreen-ils.org/cgi-bin/mailman/listinfo/evergreen-dev</a><br>
</blockquote></div>