[Evergreen-general] Group Penalty Thresholds and definition of Exceeds

[Josh Stompro]

Hello, we just noticed that our group penalty thresholds were not operating
like we thought they were.

The documentation uses the term exceeds quite a bit.

Group Penalty Thresholds block circulation transactions for users who
exceed maximum check out
limits, number of overdue items, or fines. Settings for your library are
visible under
Administration → Local Administration→ Group Penalty Thresholds. There are
four penalties
in use now.
• PATRON_EXCEEDS_FINES: Blocks new circulations and renewals if patron
exceeds X in fines
• PATRON_EXCEEDS_OVERDUE_COUNT: Blocks new circulations if patron exceeds X
overdue
items
...

My understanding of exceeds is that it is equivalent to the greater than
operator.  But it seems as if evergreen applies a greater than or equal to
comparison for the thresholds.

We have (Running 3.3) a exceeds fines threshold set to 29.99 since we
wanted everyone owing $30 or more to get the block, but just noticed that a
customer that owes exactly $29.99 received the block.

I looked at the penalty calculation sql function, and it seems to be using
>= and not just >.
https://git.evergreen-ils.org/?p=Evergreen.git;a=blob;f=Open-ILS/src/sql/Pg/100.circ_matrix.sql;hb=HEAD#l744

So I'm wondering if

   1. My understanding of the term exceed is wrong.
   2. I'm not understanding the code correctly and it isn't using >=.
   3. The code is wrong and it should just be greater than.
   4. The documentation is wrong and should say "equals or exceeds the
   threshold".

Thanks
Josh


-- 
Josh Stompro - IT Director
Lake Agassiz Regional Library
Desk: 218-233-3757 Ext 139
Cell: 218-790-2110
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://list.evergreen-ils.org/pipermail/evergreen-general/attachments/20201006/e2dd8bf2/attachment.html>