<div dir="ltr">Hi Linda,<div><br></div><div>Here's another issue I can't really explain, but may have a fix if you are up for some experimentation. </div><div><br></div><div>I've noticed in the past, other i18n issues have been resolved by applying the i18n attribute in a more targeted fashion. In the link you are having issues with has room for improvement in this regard.</div><div><br></div><div>1. Apply this patch: <a href="https://gist.github.com/berick/47a85e0f32f639b6ea94e8b66ec01862">https://gist.github.com/berick/47a85e0f32f639b6ea94e8b66ec01862</a></div><div><br></div><div>2. cd Open-ILS/src/eg2 ; npm run export-strings</div><div><br></div><div>3. Find the ID of the new "home" string in src/locale/messages.xmb. It will look something like this:</div><div> <msg id="4976935068632868195"><source>app/staff/nav.component.html:9</source>home</msg><br></div><div><br></div><div>4. Modify ./src/locale/messages.cs-CZ.xtb and change the ID of the broken home translation to this new ID and change the content of the translation to just the 'home' translation. Something like:</div><div><br></div><div><translation id="NEW-ID-GOES-HERE">domů</translation><br></div><div><br></div><div>5. Rebuild and deploy (npm run build-cs-CZ, etc.)</div><div><br></div><div>If this fixes it, I can push the patch to a LP entry.</div><div><br></div><div>Regarding your question about removing the tags in the translation, there will be drawbacks to doing that. You'll need to leave those in place. However, there are ways to reduce the occurrence of those types of control tags by using more targeted i18n attributes, but that comes at the cost (in some cases) of breaking up phrases and sentences into individual words, which could affect the meaning in translation.</div><div><br></div><div>Hope this helps / works,</div><div><br></div><div>-b</div><div><br></div><div><br></div><div><br></div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Sat, Nov 7, 2020 at 5:14 AM Linda Jansová <<a href="mailto:linda.jansova@gmail.com">linda.jansova@gmail.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<div>
<p> </p>
<p style="margin-bottom:0cm;line-height:100%">
Dear all,</p>
<p style="margin-bottom:0cm;line-height:100%">In our 3.5 install,
we have successfully managed to clean up the translation so that
the
open box characters do not appear alongside the proper
translation.
Thank you once again for providing guidance on how to correctly
make
the changes!</p>
<p style="margin-bottom:0cm;line-height:100%">The next issue we
would like to tackle is the eg2 home icon and its accompanying
(alternative) text.</p>
<p style="margin-bottom:0cm;line-height:100%">When the
translation
string is kept in its original format, only the "ů" letter shows
up (instead of the graphical home icon with a full string which
would read "domů" or "Domů").</p>
<p style="margin-bottom:0cm;line-height:100%">As can be seen at:</p>
<p style="margin-bottom:0cm;line-height:100%"><a href="https://git.evergreen-ils.org/?p=Evergreen.git;a=blob;f=Open-ILS/src/eg2/src/locale/messages.cs-CZ.xtb;hb=f07a7888b9d5368308218a32ca330eeaa1ae633c" target="_blank">https://git.evergreen-ils.org/?p=Evergreen.git;a=blob;f=Open-ILS/src/eg2/src/locale/messages.cs-CZ.xtb;hb=f07a7888b9d5368308218a32ca330eeaa1ae633c</a></p>
<p style="margin-bottom:0cm;line-height:100%">the translation
string in question is this one:</p>
<p style="margin-bottom:0cm;line-height:100%"><translation
id="3032413414186270145"> <ph
name="START_TAG_SPAN"><ex><span></ex></ph>domů<ph
name="CLOSE_TAG_SPAN"><ex></span></ex></ph></p>
<p style="margin-bottom:0cm;line-height:100%">␣␣␣␣␣␣␣␣</translation></p>
<p style="margin-bottom:0cm;line-height:100%">(The same
translation string as currently included in Poeditor can be seen
in
the attached home_link_translation_in_poeditor.png file.)</p>
<p style="margin-bottom:0cm;line-height:100%">After we changed it
(in our 3.5 install) to:</p>
<p style="margin-bottom:0cm;line-height:100%"><translation
id="3032413414186270145">Domů</translation></p>
<p style="margin-bottom:0cm;line-height:100%">we can see the full
string "Domů" instead of just the last letter "ů" (please see the
attached
home_link_in_eg2.png screenshot).</p>
<p style="margin-bottom:0cm;line-height:100%">However, the home
icon still seems to be missing from the translated interface.</p>
<p style="margin-bottom:0cm;line-height:100%">Is there a way to
make it show up even in this non-English interface?</p>
<p style="margin-bottom:0cm;line-height:100%">And on a related
note - could there be
any drawbacks when the „<ph name="START_TAG_SPAN">“
etc. code is removed?</p>
<p style="margin-bottom:0cm;line-height:100%">Thank you in
advance
for any hints!</p>
<p style="margin-bottom:0cm;line-height:100%">Linda</p>
<p>
</p>
</div>
_______________________________________________<br>
Evergreen-general mailing list<br>
<a href="mailto:Evergreen-general@list.evergreen-ils.org" target="_blank">Evergreen-general@list.evergreen-ils.org</a><br>
<a href="http://list.evergreen-ils.org/cgi-bin/mailman/listinfo/evergreen-general" rel="noreferrer" target="_blank">http://list.evergreen-ils.org/cgi-bin/mailman/listinfo/evergreen-general</a><br>
</blockquote></div>