<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
</head>
<body>
<div class="moz-cite-prefix">Hi Bill,</div>
<div class="moz-cite-prefix"><br>
</div>
<div class="moz-cite-prefix">We have tested your patch but
unfortunately it seems that it does not solve the issue. The
letter "ů" is still present and the home icon does not show up.</div>
<div class="moz-cite-prefix"><br>
</div>
<div class="moz-cite-prefix">We work with the official Evergreen
3.5.1 distribution tarball, not with a development version.</div>
<p>But step 4.1 from the installation instructions for developers
(<a class="moz-txt-link-freetext" href="https://evergreen-ils.org/documentation/install/README_3_5.html#install_files_for_web_staff_client">https://evergreen-ils.org/documentation/install/README_3_5.html#install_files_for_web_staff_client</a>)
fails to work in our case. The following step (4.2 as described at
<a class="moz-txt-link-freetext" href="https://evergreen-ils.org/documentation/install/README_3_5.html#install_files_for_angular_web_staff_client">https://evergreen-ils.org/documentation/install/README_3_5.html#install_files_for_angular_web_staff_client</a>)
works fine and also the subsequent rebuild (npm run build-cs-CZ,
etc.).</p>
<p>Is the solution you propose also supposed to work with the
official distribution tarball?</p>
<p>Thank you for sharing any insights on this!</p>
<p>Linda</p>
On 11/10/20 9:04 AM, Linda Jansová wrote:<br>
<blockquote type="cite"
cite="mid:a3b126b6-2d1c-0eff-1b3f-3e60d7cb0611@gmail.com">
<div class="moz-cite-prefix">Hi Bill,</div>
<div class="moz-cite-prefix"><br>
</div>
<div class="moz-cite-prefix">Thank you very much for a detailed
list of steps to take! After we test your patch, we will let you
know whether it works as expected :-).</div>
<div class="moz-cite-prefix"><br>
</div>
<div class="moz-cite-prefix">Thanks once again!<br>
</div>
<div class="moz-cite-prefix"><br>
</div>
<div class="moz-cite-prefix">Linda</div>
<div class="moz-cite-prefix"><br>
</div>
<div class="moz-cite-prefix">On 11/9/20 9:24 PM, Bill Erickson
wrote:<br>
</div>
<blockquote type="cite"
cite="mid:CAEjrdbphrFpUsNdwae4ROfTSCgkeUePfZrdpa48s0uCJoTzs+Q@mail.gmail.com">
<div dir="ltr">Hi Linda,
<div><br>
</div>
<div>Here's another issue I can't really explain, but may have
a fix if you are up for some experimentation. </div>
<div><br>
</div>
<div>I've noticed in the past, other i18n issues have been
resolved by applying the i18n attribute in a more targeted
fashion. In the link you are having issues with has room
for improvement in this regard.</div>
<div><br>
</div>
<div>1. Apply this patch: <a
href="https://gist.github.com/berick/47a85e0f32f639b6ea94e8b66ec01862"
moz-do-not-send="true">https://gist.github.com/berick/47a85e0f32f639b6ea94e8b66ec01862</a></div>
<div><br>
</div>
<div>2. cd Open-ILS/src/eg2 ; npm run export-strings</div>
<div><br>
</div>
<div>3. Find the ID of the new "home" string
in src/locale/messages.xmb. It will look something like
this:</div>
<div> <msg
id="4976935068632868195"><source>app/staff/nav.component.html:9</source>home</msg><br>
</div>
<div><br>
</div>
<div>4. Modify ./src/locale/messages.cs-CZ.xtb and change the
ID of the broken home translation to this new ID and change
the content of the translation to just the 'home'
translation. Something like:</div>
<div><br>
</div>
<div><translation
id="NEW-ID-GOES-HERE">domů</translation><br>
</div>
<div><br>
</div>
<div>5. Rebuild and deploy (npm run build-cs-CZ, etc.)</div>
<div><br>
</div>
<div>If this fixes it, I can push the patch to a LP entry.</div>
<div><br>
</div>
<div>Regarding your question about removing the tags in the
translation, there will be drawbacks to doing that. You'll
need to leave those in place. However, there are ways to
reduce the occurrence of those types of control tags by
using more targeted i18n attributes, but that comes at the
cost (in some cases) of breaking up phrases and sentences
into individual words, which could affect the meaning in
translation.</div>
<div><br>
</div>
<div>Hope this helps / works,</div>
<div><br>
</div>
<div>-b</div>
<div><br>
</div>
<div><br>
</div>
<div><br>
</div>
</div>
<br>
<div class="gmail_quote">
<div dir="ltr" class="gmail_attr">On Sat, Nov 7, 2020 at 5:14
AM Linda Jansová <<a
href="mailto:linda.jansova@gmail.com"
moz-do-not-send="true">linda.jansova@gmail.com</a>>
wrote:<br>
</div>
<blockquote class="gmail_quote">
<div>
<p> </p>
<p> Dear all,</p>
<p>In our 3.5 install, we have successfully managed to
clean up the translation so that the open box characters
do not appear alongside the proper translation. Thank
you once again for providing guidance on how to
correctly make the changes!</p>
<p>The next issue we would like to tackle is the eg2 home
icon and its accompanying (alternative) text.</p>
<p>When the translation string is kept in its original
format, only the "ů" letter shows up (instead of the
graphical home icon with a full string which would read
"domů" or "Domů").</p>
<p>As can be seen at:</p>
<p><a
href="https://git.evergreen-ils.org/?p=Evergreen.git;a=blob;f=Open-ILS/src/eg2/src/locale/messages.cs-CZ.xtb;hb=f07a7888b9d5368308218a32ca330eeaa1ae633c"
target="_blank" moz-do-not-send="true">https://git.evergreen-ils.org/?p=Evergreen.git;a=blob;f=Open-ILS/src/eg2/src/locale/messages.cs-CZ.xtb;hb=f07a7888b9d5368308218a32ca330eeaa1ae633c</a></p>
<p>the translation string in question is this one:</p>
<p><translation id="3032413414186270145"> <ph
name="START_TAG_SPAN"><ex><span></ex></ph>domů<ph
name="CLOSE_TAG_SPAN"><ex></span></ex></ph></p>
<p>␣␣␣␣␣␣␣␣</translation></p>
<p>(The same translation string as currently included in
Poeditor can be seen in the attached
home_link_translation_in_poeditor.png file.)</p>
<p>After we changed it (in our 3.5 install) to:</p>
<p><translation
id="3032413414186270145">Domů</translation></p>
<p>we can see the full string "Domů" instead of just the
last letter "ů" (please see the attached
home_link_in_eg2.png screenshot).</p>
<p>However, the home icon still seems to be missing from
the translated interface.</p>
<p>Is there a way to make it show up even in this
non-English interface?</p>
<p>And on a related note - could there be any drawbacks
when the „<ph name="START_TAG_SPAN">“ etc. code is
removed?</p>
<p>Thank you in advance for any hints!</p>
<p>Linda</p>
<p> </p>
</div>
_______________________________________________<br>
Evergreen-general mailing list<br>
<a href="mailto:Evergreen-general@list.evergreen-ils.org"
target="_blank" moz-do-not-send="true">Evergreen-general@list.evergreen-ils.org</a><br>
<a
href="http://list.evergreen-ils.org/cgi-bin/mailman/listinfo/evergreen-general"
rel="noreferrer" target="_blank" moz-do-not-send="true">http://list.evergreen-ils.org/cgi-bin/mailman/listinfo/evergreen-general</a><br>
</blockquote>
</div>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<pre class="moz-quote-pre" wrap="">_______________________________________________
Evergreen-general mailing list
<a class="moz-txt-link-abbreviated" href="mailto:Evergreen-general@list.evergreen-ils.org" moz-do-not-send="true">Evergreen-general@list.evergreen-ils.org</a>
<a class="moz-txt-link-freetext" href="http://list.evergreen-ils.org/cgi-bin/mailman/listinfo/evergreen-general" moz-do-not-send="true">http://list.evergreen-ils.org/cgi-bin/mailman/listinfo/evergreen-general</a>
</pre>
</blockquote>
<p><br>
</p>
</blockquote>
<p><br>
</p>
</body>
</html>