[OPEN-ILS-DEV] PATCH: Improve generation of JS prop files from DTDs

Mike Rylander mrylander at gmail.com
Tue Aug 7 11:25:48 EDT 2007


On 8/3/07, Dan Scott <denials at gmail.com> wrote:
> The attached patch:
>
> 1) Modifies dtd2js.sh so that it uses relative directories, which are
> almost guaranteed to be correct, rather than relying on shell
> expansion to point to the specific location of the Subversion checkout
> in a home directory
>
> 2) Modifies dtd2js.pl to be a little more robust in case of entity
> definitions that include mixed quotes
>
> 3) Modifies the staff_client/Makefile so that the lang.js file is
> generated for both the versionless and the stamped version of the
> staff client.

Patch applied, and ...

>
> In addition to a general cleanup of the JS prop file generation code,
> I believe this patch should enable the successful application of my
> previous patch for moving hardcoded strings out of the /main/*.xul
> files. Haven't tested it yet, though; I'll let you know how that goes.
>
> Question: as lang.js is a generated file, should we not remove it from
> the repository?
>

... probably.  Jason?

-- 
Mike Rylander
Equinox Software, Inc
miker at esilibrary.com
http://esilibrary.com/


More information about the Open-ils-dev mailing list