[OPEN-ILS-DEV] PATCH: utils.c (*_proc_title)

[Scott McKellar]

This small and inoffensive patch concerns two functions in utils.c: 
init_proc_title() and set_proc_title().

1. I added some comments to explain what these functions do for a
living.

When I first started digging into the code I found these functions
very peculiar and puzzling.  Maybe some comments will enable someone
else to avoid some head-scratching.

Of course if my proposed comments are wrong, misleading, or 
incomplete, you can change them as needed.  Alternatively maybe they
belong in the header file instead.  The header has some comments
but they don't really explain the purpose.

2. I declared the __global_argv and __global_argv_size variables
static.  No other source file refers to them.

3. I removed the leading underscores from their names.  Identifiers
beginning with two underscores are reserved for the implementation.

Scott McKellar
http://home.swbell.net/mck9/aargh/

Developer's Certificate of Origin 1.1 By making a contribution to
this project, I certify that:

(a) The contribution was created in whole or in part by me and I
have the right to submit it under the open source license indicated
in the file; or

(b) The contribution is based upon previous work that, to the best
of my knowledge, is covered under an appropriate open source license
and I have the right under that license to submit that work with
modifications, whether created in whole or in part by me, under the
same open source license (unless I am permitted to submit under a
different license), as indicated in the file; or

(c) The contribution was provided directly to me by some other person
who certified (a), (b) or (c) and I have not modified it; and

(d) In the case of each of (a), (b), or (c), I understand and agree
that this project and the contribution are public and that a record
of the contribution (including all personal information I submit
with it, including my sign-off) is maintained indefinitely and may
be redistributed consistent with this project or the open source
license indicated in the file.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: utils_c_3.patch
Type: text/x-patch
Size: 1743 bytes
Desc: 3413265321-utils_c_3.patch
Url : http://list.georgialibraries.org/pipermail/open-ils-dev/attachments/20070609/56468ce6/utils_c_3.bin