[OPEN-ILS-DEV] PATCH: osrfConfig.c (memory leak)

[Scott McKellar]

This patch plugs a minor memory leak in osrfConfigInit().  I say
"minor" because, if it the leak ever occurs, we will probably terminate
the program anyway in short order.

We start by allocating an osrfConfig.  Then we create a jsonObject
with which to populate it.  However if we run into problems creating
the jsonObject, we return NULL without deallocating the osrfConfig.

I could have stuck a free() into a couple of spots.  However I chose
to rearrange the sequence of allocations so that no such free()
would be necessary.  Specifically I allocate the osrfConfig toward the
end instead of at the beginning, and only when I know that I have
successfully created a jsonObject with which to populate it.

Scott McKellar
http://home.swbell.net/mck9/aargh/

Developer's Certificate of Origin 1.1 By making a contribution to
this project, I certify that:

(a) The contribution was created in whole or in part by me and I
have the right to submit it under the open source license indicated
in the file; or

(b) The contribution is based upon previous work that, to the best
of my knowledge, is covered under an appropriate open source license
and I have the right under that license to submit that work with
modifications, whether created in whole or in part by me, under the
same open source license (unless I am permitted to submit under a
different license), as indicated in the file; or

(c) The contribution was provided directly to me by some other person
who certified (a), (b) or (c) and I have not modified it; and

(d) In the case of each of (a), (b), or (c), I understand and agree
that this project and the contribution are public and that a record
of the contribution (including all personal information I submit
with it, including my sign-off) is maintained indefinitely and may
be redistributed consistent with this project or the open source
license indicated in the file.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: osrfConfig_c_2.patch
Type: text/x-patch
Size: 1693 bytes
Desc: 769843373-osrfConfig_c_2.patch
Url : http://list.georgialibraries.org/pipermail/open-ils-dev/attachments/20070609/37f984de/osrfConfig_c_2.bin